From 7074684474f51b6ee3ceaaf4109ba2ae263974cd Mon Sep 17 00:00:00 2001 From: Jordan Rose Date: Mon, 4 Aug 2025 10:55:22 -0700 Subject: [PATCH] Avoid reallocation inserting logs into database --- .../java/org/thoughtcrime/securesms/database/LogDatabase.kt | 2 +- .../java/org/thoughtcrime/securesms/logging/PersistentLogger.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/LogDatabase.kt b/app/src/main/java/org/thoughtcrime/securesms/database/LogDatabase.kt index 65b01bc9f8..f099900522 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/database/LogDatabase.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/database/LogDatabase.kt @@ -160,7 +160,7 @@ class LogDatabase private constructor( private val readableDatabase: SQLiteDatabase get() = openHelper.readableDatabase private val writableDatabase: SQLiteDatabase get() = openHelper.writableDatabase - fun insert(logs: List, currentTime: Long) { + fun insert(logs: Sequence, currentTime: Long) { writableDatabase.withinTransaction { db -> logs.forEach { log -> db.insertInto(TABLE_NAME) diff --git a/app/src/main/java/org/thoughtcrime/securesms/logging/PersistentLogger.kt b/app/src/main/java/org/thoughtcrime/securesms/logging/PersistentLogger.kt index 3d08bda83f..c5f088f917 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/logging/PersistentLogger.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/logging/PersistentLogger.kt @@ -126,7 +126,7 @@ class PersistentLogger private constructor(application: Application) : Log.Logge override fun run() { while (true) { requests.blockForRequests(buffer) - db.logs.insert(buffer.flatMap { requestToEntries(it) }, System.currentTimeMillis()) + db.logs.insert(buffer.asSequence().flatMap { requestToEntries(it) }, System.currentTimeMillis()) buffer.clear() requests.notifyFlushed() }