Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-23 10:20:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when downloading attachment from S3.

Browse Source
This commit is contained in:
Greyson Parrelli
2024-09-10 20:47:13 -04:00
committed by Cody Henthorne
parent 36a8a399d9
commit 7735ca9dab
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/thoughtcrime/securesms/database/AttachmentTable.kt
View File

@@ -981,9 +981,10 @@ class AttachmentTable(
limitStream.leftoverStream().allMatch { it == 0x00.toByte() }
}
val digest = if (paddingAllZeroes) {
// Existing digest may be null for non-user attachments, like things pulled from S3
val digest = if (existingPlaceholder.remoteDigest != null && paddingAllZeroes) {
Log.d(TAG, "[finalizeAttachmentAfterDownload] $attachmentId has all-zero padding. Digest is good.")
existingPlaceholder.remoteDigest!!
existingPlaceholder.remoteDigest
} else {
Log.w(TAG, "[finalizeAttachmentAfterDownload] $attachmentId has non-zero padding bytes. Recomputing digest.")