diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/ThreadBodyUtil.java b/app/src/main/java/org/thoughtcrime/securesms/database/ThreadBodyUtil.java index 0492a45a14..7e99feb42c 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/database/ThreadBodyUtil.java +++ b/app/src/main/java/org/thoughtcrime/securesms/database/ThreadBodyUtil.java @@ -74,8 +74,8 @@ public final class ThreadBodyUtil { } else if (MessageRecordUtil.hasPoll(record)) { return new ThreadBody(context.getString(R.string.Poll__poll_question, record.getPoll().getQuestion())); } else if (MessageRecordUtil.hasPollTerminate(record)) { - String creator = record.getFromRecipient().isSelf() ? context.getResources().getString(R.string.MessageRecord_you) : record.getFromRecipient().getDisplayName(context); - return new ThreadBody(context.getString(R.string.Poll__poll_end, creator, record.getMessageExtras().pollTerminate.question)); + return record.getFromRecipient().isSelf() ? new ThreadBody(context.getString(R.string.Poll__you_poll_end, record.getMessageExtras().pollTerminate.question)) + : new ThreadBody(context.getString(R.string.Poll__poll_end, record.getFromRecipient().getDisplayName(context), record.getMessageExtras().pollTerminate.question)); } boolean hasImage = false; diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/model/MessageRecord.java b/app/src/main/java/org/thoughtcrime/securesms/database/model/MessageRecord.java index 306ce4cbe0..57f0806bd8 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/database/model/MessageRecord.java +++ b/app/src/main/java/org/thoughtcrime/securesms/database/model/MessageRecord.java @@ -295,8 +295,8 @@ public abstract class MessageRecord extends DisplayRecord { } else if (isUnsupported()) { return staticUpdateDescription(context.getString(R.string.MessageRecord_unsupported_feature, getFromRecipient().getDisplayName(context)), Glyph.ERROR); } else if (MessageRecordUtil.hasPollTerminate(this)) { - String creator = getFromRecipient().isSelf() ? context.getString(R.string.MessageRecord_you) : getFromRecipient().getDisplayName(context); - return staticUpdateDescriptionWithExpiration(context.getString(R.string.MessageRecord_ended_the_poll, creator, messageExtras.pollTerminate.question), Glyph.POLL); + return getFromRecipient().isSelf() ? staticUpdateDescriptionWithExpiration(context.getString(R.string.MessageRecord_you_ended_the_poll, messageExtras.pollTerminate.question), Glyph.POLL) + : staticUpdateDescriptionWithExpiration(context.getString(R.string.MessageRecord_ended_the_poll, getFromRecipient().getDisplayName(context), messageExtras.pollTerminate.question), Glyph.POLL); } return null; diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 6e66e46c21..0cbf4b94df 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -2125,6 +2125,8 @@ %1$s sent you a message that can\'t be processed or displayed because it uses a new Signal feature. %1$s ended the poll: \"%2$s\" + + You ended the poll: \"%1$s\" Accept @@ -8860,6 +8862,8 @@ Poll: %1$s %1$s ended the poll: \"%2$s\" + + You ended the poll: \"%1$s\" %1$s voted in the poll: \"%2$s\"