From 7ef77bf16c2f1bbb5e0083f369f2d3f0c9292f58 Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Sun, 3 Jan 2021 00:50:01 -0500
Subject: [PATCH] Remove unbounded conversation list query.

---
 .../securesms/components/reminder/ShareReminder.java      | 8 +-------
 .../thoughtcrime/securesms/database/ThreadDatabase.java   | 4 ----
 .../securesms/recipients/LiveRecipientCache.java          | 2 +-
 3 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/reminder/ShareReminder.java b/app/src/main/java/org/thoughtcrime/securesms/components/reminder/ShareReminder.java
index 89815537c3..6da847515a 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/components/reminder/ShareReminder.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/reminder/ShareReminder.java
@@ -40,12 +40,6 @@ public class ShareReminder extends Reminder {
       return false;
     }
 
-    Cursor cursor = null;
-    try {
-      cursor = DatabaseFactory.getThreadDatabase(context).getConversationList();
-      return cursor.getCount() >= 1;
-    } finally {
-      if (cursor != null) cursor.close();
-    }
+    return DatabaseFactory.getThreadDatabase(context).getUnarchivedConversationListCount() >= 1;
   }
 }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java b/app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java
index cc791f0e95..c7bf66fc04 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java
@@ -604,10 +604,6 @@ public class ThreadDatabase extends Database {
     return threadRecords;
   }
 
-  public Cursor getConversationList() {
-    return getConversationList("0");
-  }
-
   public Cursor getArchivedConversationList() {
     return getConversationList("1");
   }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/recipients/LiveRecipientCache.java b/app/src/main/java/org/thoughtcrime/securesms/recipients/LiveRecipientCache.java
index 62a58d4821..502de4557a 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/recipients/LiveRecipientCache.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/recipients/LiveRecipientCache.java
@@ -149,7 +149,7 @@ public final class LiveRecipientCache {
       ThreadDatabase  threadDatabase = DatabaseFactory.getThreadDatabase(context);
       List<Recipient> recipients     = new ArrayList<>();
 
-      try (ThreadDatabase.Reader reader = threadDatabase.readerFor(threadDatabase.getConversationList())) {
+      try (ThreadDatabase.Reader reader = threadDatabase.readerFor(threadDatabase.getRecentConversationList(CACHE_WARM_MAX, false, false))) {
         int          i      = 0;
         ThreadRecord record = null;