Fix incorrectly oriented back navigation icons for top app bar RTL layouts.

Replace `symbol_arrow_left_24` with `symbol_arrow_start_24` (which has auto-mirroring enabled) for top app bar navigation back icons to properly support RTL layouts.
2025-12-27 14:40:22 +00:00 · 2025-04-03 10:13:41 -04:00
parent 5b04107447
commit 85b19bfe23
23 changed files with 24 additions and 23 deletions
--- a/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsKeyEducationScreen.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsKeyEducationScreen.kt
@@ -39,7 +39,7 @@ fun MessageBackupsKeyEducationScreen(
 ) {
  Scaffolds.Settings(
    title = "",
-    navigationIconPainter = painterResource(R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(R.drawable.symbol_arrow_start_24),
    onNavigationClick = onNavigationClick
  ) {
    Column(
--- a/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsKeyRecordScreen.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsKeyRecordScreen.kt
@@ -55,7 +55,7 @@ fun MessageBackupsKeyRecordScreen(

  Scaffolds.Settings(
    title = "",
-    navigationIconPainter = painterResource(R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(R.drawable.symbol_arrow_start_24),
    onNavigationClick = onNavigationClick
  ) { paddingValues ->
    Column(
--- a/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsKeyVerifyScreen.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsKeyVerifyScreen.kt
@@ -87,7 +87,7 @@ fun MessageBackupsKeyVerifyScreen(

  Scaffolds.Settings(
    title = stringResource(R.string.MessageBackupsKeyVerifyScreen__confirm_your_backup_key),
-    navigationIconPainter = painterResource(R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(R.drawable.symbol_arrow_start_24),
    onNavigationClick = onNavigationClick
  ) { paddingValues ->

--- a/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsTypeSelectionScreen.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/backup/v2/ui/subscription/MessageBackupsTypeSelectionScreen.kt
@@ -82,7 +82,7 @@ fun MessageBackupsTypeSelectionScreen(
  Scaffolds.Settings(
    title = "",
    onNavigationClick = onNavigationClick,
-    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24)
+    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24)
  ) { paddingValues ->
    Column(
      modifier = Modifier
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/AppSettingsFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/AppSettingsFragment.kt
@@ -181,7 +181,7 @@ private fun AppSettingsContent(
  Scaffolds.Settings(
    title = stringResource(R.string.text_secure_normal__menu_settings),
    navigationContentDescription = stringResource(R.string.CallScreenTopBar__go_back),
-    navigationIconPainter = painterResource(R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(R.drawable.symbol_arrow_start_24),
    onNavigationClick = callbacks::onNavigationClick
  ) { contentPadding ->
    Column(
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/backups/BackupsSettingsFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/backups/BackupsSettingsFragment.kt
@@ -114,7 +114,7 @@ private fun BackupsSettingsContent(
 ) {
  Scaffolds.Settings(
    title = stringResource(R.string.preferences_chats__backups),
-    navigationIconPainter = painterResource(R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(R.drawable.symbol_arrow_start_24),
    onNavigationClick = onNavigationClick
  ) { paddingValues ->
    LazyColumn(
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/backups/remote/RemoteBackupsSettingsFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/backups/remote/RemoteBackupsSettingsFragment.kt
@@ -363,7 +363,7 @@ private fun RemoteBackupsSettingsContent(
  Scaffolds.Settings(
    title = stringResource(id = R.string.RemoteBackupsSettingsFragment__signal_backups),
    onNavigationClick = contentCallbacks::onNavigationClick,
-    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24),
    snackbarHost = {
      Snackbars.Host(snackbarHostState = snackbarHostState)
    }
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/InternalPendingOneTimeDonationConfigurationFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/InternalPendingOneTimeDonationConfigurationFragment.kt
@@ -109,7 +109,7 @@ private fun Content(
 ) {
  Scaffolds.Settings(
    title = "One-time donation state",
-    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24),
    navigationContentDescription = null,
    onNavigationClick = onNavigationClick
  ) {
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/backup/InternalBackupPlaygroundFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/backup/InternalBackupPlaygroundFragment.kt
@@ -285,7 +285,7 @@ fun Tabs(
          navigationIcon = {
            IconButton(onClick = onBack) {
              Icon(
-                painter = painterResource(R.drawable.symbol_arrow_left_24),
+                painter = painterResource(R.drawable.symbol_arrow_start_24),
                tint = MaterialTheme.colorScheme.onSurface,
                contentDescription = null
              )
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/sqlite/InternalSqlitePlaygroundFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/sqlite/InternalSqlitePlaygroundFragment.kt
@@ -85,7 +85,7 @@ private fun Screen(
        navigationIcon = {
          IconButton(onClick = onBackPressed) {
            Icon(
-              painter = painterResource(R.drawable.symbol_arrow_left_24),
+              painter = painterResource(R.drawable.symbol_arrow_start_24),
              tint = MaterialTheme.colorScheme.onSurface,
              contentDescription = null
            )
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/storage/InternalStorageServicePlaygroundFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/internal/storage/InternalStorageServicePlaygroundFragment.kt
@@ -110,7 +110,7 @@ fun Screen(
          navigationIcon = {
            IconButton(onClick = onBackPressed) {
              Icon(
-                painter = painterResource(R.drawable.symbol_arrow_left_24),
+                painter = painterResource(R.drawable.symbol_arrow_start_24),
                tint = MaterialTheme.colorScheme.onSurface,
                contentDescription = null
              )
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/subscription/donate/transfer/details/BankTransferDetailsFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/subscription/donate/transfer/details/BankTransferDetailsFragment.kt
@@ -202,7 +202,7 @@ private fun BankTransferDetailsContent(
  Scaffolds.Settings(
    title = "Bank transfer",
    onNavigationClick = onNavigationClick,
-    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24)
+    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24)
  ) {
    Column(
      horizontalAlignment = CenterHorizontally,
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/subscription/donate/transfer/ideal/IdealTransferDetailsFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/subscription/donate/transfer/ideal/IdealTransferDetailsFragment.kt
@@ -228,7 +228,7 @@ private fun IdealTransferDetailsContent(
  Scaffolds.Settings(
    title = stringResource(id = R.string.GatewaySelectorBottomSheet__ideal),
    onNavigationClick = onNavigationClick,
-    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24)
+    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24)
  ) {
    val focusManager = LocalFocusManager.current

--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/subscription/donate/transfer/mandate/BankTransferMandateFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/subscription/donate/transfer/mandate/BankTransferMandateFragment.kt
@@ -171,7 +171,7 @@ fun BankTransferScreen(
            Modifier.padding(end = 16.dp)
          ) {
            Icon(
-              painter = rememberVectorPainter(ImageVector.vectorResource(id = R.drawable.symbol_arrow_left_24)),
+              painter = rememberVectorPainter(ImageVector.vectorResource(id = R.drawable.symbol_arrow_start_24)),
              contentDescription = null
            )
          }
--- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/usernamelinks/colorpicker/UsernameLinkQrColorPickerFragment.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/usernamelinks/colorpicker/UsernameLinkQrColorPickerFragment.kt
@@ -121,7 +121,7 @@ class UsernameLinkQrColorPickerFragment : ComposeFragment() {
      navigationIcon = {
        IconButton(onClick = onBackClicked) {
          Icon(
-            painter = painterResource(R.drawable.symbol_arrow_left_24),
+            painter = painterResource(R.drawable.symbol_arrow_start_24),
            tint = MaterialTheme.colorScheme.onSurface,
            contentDescription = null
          )
--- a/app/src/main/java/org/thoughtcrime/securesms/components/webrtc/v2/CallScreenTopBar.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/components/webrtc/v2/CallScreenTopBar.kt
@@ -176,7 +176,7 @@ fun CallScreenTopAppBar(
        onClick = onNavigationClick
      ) {
        Icon(
-          painter = painterResource(id = R.drawable.symbol_arrow_left_24),
+          painter = painterResource(id = R.drawable.symbol_arrow_start_24),
          contentDescription = stringResource(id = R.string.CallScreenTopBar__go_back),
          tint = Color.White
        )
--- a/app/src/main/java/org/thoughtcrime/securesms/groups/ui/incommon/GroupsInCommonActivity.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/groups/ui/incommon/GroupsInCommonActivity.kt
@@ -140,7 +140,7 @@ private fun TopAppBar(
  Scaffolds.DefaultTopAppBar(
    title = pluralStringResource(R.plurals.GroupsInCommon__n_groups_in_common_title, groupCount, NumberFormat.getInstance().format(groupCount)),
    titleContent = { _, title -> Text(text = title, style = MaterialTheme.typography.titleLarge) },
-    navigationIconPainter = painterResource(R.drawable.symbol_arrow_left_24),
+    navigationIconPainter = painterResource(R.drawable.symbol_arrow_start_24),
    onNavigationClick = onBackPress,
    scrollBehavior = scrollBehavior
  )
--- a/app/src/main/java/org/thoughtcrime/securesms/main/MainToolbar.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/main/MainToolbar.kt
@@ -221,7 +221,7 @@ private fun SearchToolbar(
          onClick = callback::onCloseSearchClick
        ) {
          Icon(
-            imageVector = ImageVector.vectorResource(R.drawable.symbol_arrow_left_24),
+            imageVector = ImageVector.vectorResource(R.drawable.symbol_arrow_start_24),
            contentDescription = null
          )
        }
@@ -276,7 +276,7 @@ private fun ArchiveToolbar(
        callback.onCloseArchiveClick()
      }) {
        Icon(
-          imageVector = ImageVector.vectorResource(R.drawable.symbol_arrow_left_24),
+          imageVector = ImageVector.vectorResource(R.drawable.symbol_arrow_start_24),
          contentDescription = stringResource(R.string.CallScreenTopBar__go_back)
        )
      }
--- a/app/src/main/java/org/thoughtcrime/securesms/nicknames/NicknameActivity.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/nicknames/NicknameActivity.kt
@@ -217,7 +217,7 @@ private fun NicknameContent(
  Scaffolds.Settings(
    title = stringResource(id = R.string.NicknameActivity__nickname),
    onNavigationClick = callback::onNavigationClick,
-    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24)
+    navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24)
  ) { paddingValues ->

    val firstNameFocusRequester = remember { FocusRequester() }
--- a/app/src/main/java/org/thoughtcrime/securesms/recipients/ui/findby/FindByActivity.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/recipients/ui/findby/FindByActivity.kt
@@ -132,7 +132,7 @@ class FindByActivity : PassphraseRequiredActivity() {
            Scaffolds.Settings(
              title = stringResource(id = title),
              onNavigationClick = { finishAfterTransition() },
-              navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_left_24)
+              navigationIconPainter = painterResource(id = R.drawable.symbol_arrow_start_24)
            ) {
              val context = LocalContext.current

--- a/app/src/main/java/org/thoughtcrime/securesms/sharing/v2/ShareActivity.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/sharing/v2/ShareActivity.kt
@@ -110,7 +110,7 @@ class ShareActivity : PassphraseRequiredActivity(), MultiselectForwardFragment.C

    if (intent?.getBooleanExtra(EXTRA_NAVIGATION, false) == true) {
      toolbar.setTitle(getTitleFromExtras())
-      toolbar.setNavigationIcon(R.drawable.symbol_arrow_left_24)
+      toolbar.setNavigationIcon(R.drawable.symbol_arrow_start_24)
      toolbar.setNavigationOnClickListener { finish() }
    } else {
      toolbar.visible = false