Ensure lint configuration is applied to all modules.

This commit is contained in:
Alex Hart
2026-02-09 13:05:28 -04:00
committed by Greyson Parrelli
parent 2c6524f6c0
commit 879e8f98bd
21 changed files with 73 additions and 51 deletions

View File

@@ -273,7 +273,8 @@ private fun EntryProviderScope<NavKey>.navigationEntries(
// -- Country Code Picker
entry<RegistrationRoute.CountryCodePicker> {
// We'll also want this to be some sort of launch-for-result flow as well
TODO()
// TODO [registration] - display country code picker
throw NotImplementedError("Country Code Picker not implemented")
}
// -- Captcha Screen

View File

@@ -388,7 +388,8 @@ class PhoneNumberEntryViewModel(
state
}
is NetworkController.RequestVerificationCodeError.MissingRequestInformationOrAlreadyVerified -> {
TODO()
// TODO [registration] - Error handling not implemented
throw NotImplementedError()
}
is NetworkController.RequestVerificationCodeError.SessionNotFound -> {
parentEventEmitter(RegistrationFlowEvent.ResetState)

View File

@@ -72,7 +72,8 @@ class PinCreationViewModel(
)
}
is PinCreationScreenEvents.LearnMore -> {
TODO("Show learn more dialog or navigate to help screen")
// TODO [registration] - Show learn more dialog or navigate to help screen
throw NotImplementedError("Show learn more dialog or navigate to help screen")
}
}
}
@@ -104,7 +105,8 @@ class PinCreationViewModel(
when (result.error) {
is NetworkController.BackupMasterKeyError.EnclaveNotFound -> {
Log.w(TAG, "[PinSubmitted] SVR enclave not found.")
TODO("Report to UI and indicate to library user that pin could not be created")
// TODO [registration] - Report to UI and indicate to library user that pin could not be created
throw NotImplementedError("Report to UI and indicate to library user that pin could not be created")
}
is NetworkController.BackupMasterKeyError.NotRegistered -> {
Log.w(TAG, "[PinSubmitted] Account not registered. This should not happen. Resetting.")
@@ -115,11 +117,13 @@ class PinCreationViewModel(
}
is NetworkController.RegistrationNetworkResult.NetworkError -> {
Log.w(TAG, "[PinSubmitted] Network error when backing up master key.", result.exception)
TODO("Report to UI and indicate to library user that pin could not be created")
// TODO [registration] - Report to UI and indicate to library user that pin could not be created
throw NotImplementedError("Report to UI and indicate to library user that pin could not be created")
}
is NetworkController.RegistrationNetworkResult.ApplicationError -> {
Log.w(TAG, "[PinSubmitted] Application error when backing up master key.", result.exception)
TODO("Report to UI and indicate to library user that pin could not be created")
// TODO [registration] - Report to UI and indicate to library user that pin could not be created
throw NotImplementedError("Report to UI and indicate to library user that pin could not be created")
}
}
}

View File

@@ -147,7 +147,8 @@ class PinEntryForRegistrationLockViewModel(
when (registerResult.error) {
is NetworkController.RegisterAccountError.SessionNotFoundOrNotVerified -> {
Log.w(TAG, "[PinEntered] Session not found or verified: ${registerResult.error.message}")
TODO()
// TODO [registration] - Handle session not found or verified.
throw NotImplementedError("Handle session not found or verified")
}
is NetworkController.RegisterAccountError.RegistrationLock -> {
Log.w(TAG, "[PinEntered] Still getting registration lock error after providing token. This shouldn't happen. Resetting state.")
@@ -168,7 +169,8 @@ class PinEntryForRegistrationLockViewModel(
}
is NetworkController.RegisterAccountError.RegistrationRecoveryPasswordIncorrect -> {
Log.w(TAG, "[PinEntered] Registration recovery password incorrect: ${registerResult.error.message}")
TODO()
// TODO [registration] - Handle incorrect password
throw NotImplementedError("Handle incorrect password")
}
}
}
@@ -185,7 +187,7 @@ class PinEntryForRegistrationLockViewModel(
private fun handleSkip() {
Log.d(TAG, "Skip requested - this will result in account data loss after timeRemaining: $timeRemaining ms")
// TODO: Show confirmation dialog warning about data loss, then proceed without PIN
// TODO [registration] - Show confirmation dialog warning about data loss, then proceed without PIN
}
class Factory(

View File

@@ -146,7 +146,8 @@ class PinEntryForSvrRestoreViewModel(
}
private fun handleSkip() {
TODO("Handle skip")
// TODO [registration] - Handle skip
throw NotImplementedError("Handle skip")
}
class Factory(

View File

@@ -54,7 +54,7 @@ class VerificationCodeViewModel(
is VerificationCodeScreenEvents.WrongNumber -> state.also { parentEventEmitter.navigateTo(RegistrationRoute.PhoneNumberEntry) }
is VerificationCodeScreenEvents.ResendSms -> transformResendCode(state, NetworkController.VerificationCodeTransport.SMS)
is VerificationCodeScreenEvents.CallMe -> transformResendCode(state, NetworkController.VerificationCodeTransport.VOICE)
is VerificationCodeScreenEvents.HavingTrouble -> TODO("having trouble flow")
is VerificationCodeScreenEvents.HavingTrouble -> throw NotImplementedError("having trouble flow") // TODO [registration] - Having trouble flow
is VerificationCodeScreenEvents.ConsumeInnerOneTimeEvent -> state.copy(oneTimeEvent = null)
}
}
@@ -148,7 +148,8 @@ class VerificationCodeViewModel(
is NetworkController.RegistrationNetworkResult.Failure -> {
when (registerResult.error) {
is NetworkController.RegisterAccountError.SessionNotFoundOrNotVerified -> {
TODO()
// TODO [registration] Handle session not found or not verified case.
throw NotImplementedError("Handle session not found or not verified case.")
}
is NetworkController.RegisterAccountError.DeviceTransferPossible -> {
Log.w(TAG, "[Register] Got told a device transfer is possible. We should never get into this state. Resetting.")