From 8b5b83e974db5ef6bf3d0e076dc27a7aac4cd0c4 Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Wed, 1 Apr 2026 10:26:26 -0400
Subject: [PATCH] Remove unnecessary transaction in LocalMetricsDatabase.

There was a native crash associated with it, unclear the cause, but
maybe this will help.
---
 .../database/LocalMetricsDatabase.kt          | 45 +++++++------------
 1 file changed, 17 insertions(+), 28 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/LocalMetricsDatabase.kt b/app/src/main/java/org/thoughtcrime/securesms/database/LocalMetricsDatabase.kt
index 6d464aea5f..f88f897a35 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/database/LocalMetricsDatabase.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/database/LocalMetricsDatabase.kt
@@ -164,35 +164,24 @@ class LocalMetricsDatabase private constructor(
   }
 
   fun getMetrics(): List<EventMetrics> {
-    val db = readableDatabase
+    val events: Map<String, List<String>> = getUniqueEventNames()
 
-    db.beginTransaction()
-    try {
-      val events: Map<String, List<String>> = getUniqueEventNames()
-
-      val metrics: List<EventMetrics> = events.map { (eventName: String, splits: List<String>) ->
-        EventMetrics(
-          name = eventName,
-          count = getCount(eventName),
-          p50 = eventPercent(eventName, 50),
-          p90 = eventPercent(eventName, 90),
-          p99 = eventPercent(eventName, 99),
-          splits = splits.map { splitName ->
-            SplitMetrics(
-              name = splitName,
-              p50 = splitPercent(eventName, splitName, 50),
-              p90 = splitPercent(eventName, splitName, 90),
-              p99 = splitPercent(eventName, splitName, 99)
-            )
-          }
-        )
-      }
-
-      db.setTransactionSuccessful()
-
-      return metrics
-    } finally {
-      db.endTransaction()
+    return events.map { (eventName: String, splits: List<String>) ->
+      EventMetrics(
+        name = eventName,
+        count = getCount(eventName),
+        p50 = eventPercent(eventName, 50),
+        p90 = eventPercent(eventName, 90),
+        p99 = eventPercent(eventName, 99),
+        splits = splits.map { splitName ->
+          SplitMetrics(
+            name = splitName,
+            p50 = splitPercent(eventName, splitName, 50),
+            p90 = splitPercent(eventName, splitName, 90),
+            p99 = splitPercent(eventName, splitName, 99)
+          )
+        }
+      )
     }
   }