diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationFragment.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationFragment.kt index 409f6ba6a9..abd151141d 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationFragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationFragment.kt @@ -2396,7 +2396,6 @@ class ConversationFragment : if (DeleteSyncEducationDialog.shouldShow()) { DeleteSyncEducationDialog .show(childFragmentManager) - .observeOn(AndroidSchedulers.mainThread()) .subscribe { handleDeleteMessages(messageParts) } .addTo(disposables) @@ -2407,12 +2406,7 @@ class ConversationFragment : disposables += DeleteDialog.show( context = requireContext(), - messageRecords = records, - message = if (TextSecurePreferences.isMultiDevice(requireContext()) && Recipient.self().deleteSyncCapability.isSupported) { - resources.getQuantityString(R.plurals.ConversationFragment_delete_on_linked_warning, records.size) - } else { - null - } + messageRecords = records ).observeOn(AndroidSchedulers.mainThread()) .subscribe { (deleted: Boolean, _: Boolean) -> if (!deleted) return@subscribe diff --git a/app/src/main/java/org/thoughtcrime/securesms/mediaoverview/MediaActions.java b/app/src/main/java/org/thoughtcrime/securesms/mediaoverview/MediaActions.java index ee31897b76..cf623bb115 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/mediaoverview/MediaActions.java +++ b/app/src/main/java/org/thoughtcrime/securesms/mediaoverview/MediaActions.java @@ -60,20 +60,8 @@ final class MediaActions { { int recordCount = mediaRecords.size(); Resources res = context.getResources(); - String confirmTitle = res.getQuantityString(R.plurals.MediaOverviewActivity_Media_delete_confirm_title, - recordCount, - recordCount); - - String confirmMessage; - if (TextSecurePreferences.isMultiDevice(context) && Recipient.self().getDeleteSyncCapability().isSupported()) { - confirmMessage = res.getQuantityString(R.plurals.MediaOverviewActivity_Media_delete_confirm_message_linked_device, - recordCount, - recordCount); - } else { - confirmMessage = res.getQuantityString(R.plurals.MediaOverviewActivity_Media_delete_confirm_message, - recordCount, - recordCount); - } + String confirmTitle = res.getQuantityString(R.plurals.MediaOverviewActivity_Media_delete_confirm_title, recordCount, recordCount); + String confirmMessage = res.getQuantityString(R.plurals.MediaOverviewActivity_Media_delete_confirm_message, recordCount, recordCount); MaterialAlertDialogBuilder builder = new MaterialAlertDialogBuilder(context).setTitle(confirmTitle) .setMessage(confirmMessage) diff --git a/app/src/main/java/org/thoughtcrime/securesms/mediapreview/MediaPreviewV2Fragment.kt b/app/src/main/java/org/thoughtcrime/securesms/mediapreview/MediaPreviewV2Fragment.kt index 5dbbeae4cf..534a9bf2d9 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/mediapreview/MediaPreviewV2Fragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/mediapreview/MediaPreviewV2Fragment.kt @@ -73,7 +73,6 @@ import org.thoughtcrime.securesms.util.MessageConstraintsUtil import org.thoughtcrime.securesms.util.SaveAttachmentTask import org.thoughtcrime.securesms.util.SpanUtil import org.thoughtcrime.securesms.util.StorageUtil -import org.thoughtcrime.securesms.util.TextSecurePreferences import org.thoughtcrime.securesms.util.ViewUtil import org.thoughtcrime.securesms.util.visible import java.util.Locale @@ -600,7 +599,7 @@ class MediaPreviewV2Fragment : LoggingFragment(R.layout.fragment_media_preview_v MaterialAlertDialogBuilder(requireContext()).apply { setIcon(R.drawable.symbol_error_triangle_fill_24) setTitle(R.string.MediaPreviewActivity_media_delete_confirmation_title) - setMessage(if (TextSecurePreferences.isMultiDevice(requireContext()) && Recipient.self().deleteSyncCapability.isSupported) R.string.MediaPreviewActivity_media_delete_confirmation_message_linked_device else R.string.MediaPreviewActivity_media_delete_confirmation_message) + setMessage(R.string.MediaPreviewActivity_media_delete_confirmation_message) setCancelable(true) setNegativeButton(android.R.string.cancel, null) setPositiveButton(R.string.ConversationFragment_delete_for_me) { _, _ -> diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/DeleteDialog.kt b/app/src/main/java/org/thoughtcrime/securesms/util/DeleteDialog.kt index 15f836bb1a..ec95e5c9cd 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/util/DeleteDialog.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/util/DeleteDialog.kt @@ -31,8 +31,8 @@ object DeleteDialog { fun show( context: Context, messageRecords: Set, - title: CharSequence = context.resources.getQuantityString(R.plurals.ConversationFragment_delete_selected_messages, messageRecords.size, messageRecords.size), - message: CharSequence? = null, + title: CharSequence? = null, + message: CharSequence = context.resources.getQuantityString(R.plurals.ConversationFragment_delete_selected_messages, messageRecords.size, messageRecords.size), forceRemoteDelete: Boolean = false ): Single> = Single.create { emitter -> val builder = MaterialAlertDialogBuilder(context) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 5d6428984c..0c3de5a822 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -549,11 +549,6 @@ Delete Delete everywhere - - - This message will be deleted from all your devices. - These messages will be deleted from all your devices. - This message will be deleted for everyone in the chat if they’re on a recent version of Signal. They will be able to see that you deleted a message. Original message not found Original message no longer available @@ -1384,11 +1379,6 @@ This will permanently delete the selected file. Any message text associated with this item will also be deleted. This will permanently delete all %1$d selected files. Any message text associated with these items will also be deleted. - - - This will permanently delete the selected file from all your devices. Any message text associated with this item will also be deleted. - This will permanently delete all %1$d selected files from all your devices. Any message text associated with these items will also be deleted. - Deleting Deleting messages… Collecting attachments… @@ -2585,8 +2575,6 @@ Unable to save to external storage without permissions Delete message? This will permanently delete this message. - - This will permanently delete this message from all your devices. %1$s to %2$s You to %1$s @@ -7018,7 +7006,7 @@ Deleting is now synced across all of your devices - When you delete messages, media or chats, they will be deleted from your phone and all linked devices. + When you delete messages or chats, they will be deleted from your phone and linked devices. OK