Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-21 17:29:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible null column crash in V166 migration.

Browse Source 
Fixes #12672
This commit is contained in:
Greyson Parrelli
2022-12-12 09:28:32 -05:00
parent 19cbace33d
commit a2893fbec7
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/thoughtcrime/securesms/database/helpers/migration/V166_ThreadAndMessageForeignKeys.kt
View File

@@ -181,23 +181,23 @@ object V166_ThreadAndMessageForeignKeys : SignalDatabaseMigration {
private fun fixDanglingSmsMessages(db: SQLiteDatabase) {
db.delete("sms")
.where("address NOT IN (SELECT _id FROM recipient)")
.where("address IS NULL OR address NOT IN (SELECT _id FROM recipient)")
.run()
// Can't even attempt to "fix" these because without the threadId we don't know if it's a 1:1 or group message
db.delete("sms")
.where("thread_id NOT IN (SELECT _id FROM thread)")
.where("thread_id IS NULL OR thread_id NOT IN (SELECT _id FROM thread)")
.run()
}
private fun fixDanglingMmsMessages(db: SQLiteDatabase) {
db.delete("mms")
.where("address NOT IN (SELECT _id FROM recipient)")
.where("address IS NULL OR address NOT IN (SELECT _id FROM recipient)")
.run()
// Can't even attempt to "fix" these because without the threadId we don't know if it's a 1:1 or group message
db.delete("mms")
.where("thread_id NOT IN (SELECT _id FROM thread)")
.where("thread_id IS NULL OR thread_id NOT IN (SELECT _id FROM thread)")
.run()
}