Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-21 00:59:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix illegal argument navigation exceptions.

Browse Source
This commit is contained in:
Cody Henthorne
2021-12-15 16:07:54 -05:00
committed by Greyson Parrelli
parent ba54051f8c
commit a4f44a96fd
70 changed files with 337 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
app/src/main/java/org/thoughtcrime/securesms/util/navigation/SafeNavigation.kt Normal file
View File

@@ -0,0 +1,70 @@
@file:JvmName("SafeNavigation")
package org.thoughtcrime.securesms.util.navigation
import android.content.res.Resources
import android.os.Bundle
import androidx.annotation.IdRes
import androidx.navigation.NavController
import androidx.navigation.NavDirections
import androidx.navigation.NavOptions
import org.signal.core.util.logging.Log
import org.thoughtcrime.securesms.dependencies.ApplicationDependencies
private const val TAG = "SafeNavigation"
/**
* Check [currentDestination] has an action with [resId] before attempting to navigate.
*/
fun NavController.safeNavigate(@IdRes resId: Int) {
if (currentDestination?.getAction(resId) != null) {
navigate(resId)
} else {
Log.w(TAG, "Unable to find action ${getDisplayName(resId)} for $currentDestination")
}
}
/**
* Check [currentDestination] has an action with [resId] before attempting to navigate.
*/
fun NavController.safeNavigate(@IdRes resId: Int, arguments: Bundle?) {
if (currentDestination?.getAction(resId) != null) {
navigate(resId, arguments)
} else {
Log.w(TAG, "Unable to find action ${getDisplayName(resId)} for $currentDestination")
}
}
/**
* Check [currentDestination] has an action for [directions] before attempting to navigate.
*/
fun NavController.safeNavigate(directions: NavDirections) {
if (currentDestination?.getAction(directions.actionId) != null) {
navigate(directions)
} else {
Log.w(TAG, "Unable to find ${getDisplayName(directions.actionId)} for $currentDestination")
}
}
/**
* Check [currentDestination] has an action for [directions] before attempting to navigate.
*/
fun NavController.safeNavigate(directions: NavDirections, navOptions: NavOptions?) {
if (currentDestination?.getAction(directions.actionId) != null) {
navigate(directions, navOptions)
} else {
Log.w(TAG, "Unable to find ${getDisplayName(directions.actionId)} for $currentDestination")
}
}
private fun getDisplayName(id: Int): String? {
return if (id <= 0x00FFFFFF) {
id.toString()
} else {
try {
ApplicationDependencies.getApplication().resources.getResourceName(id)
} catch (e: Resources.NotFoundException) {
id.toString()
}
}
}