From a88394ffe478268ad55d474aae7b8a8a3d05d214 Mon Sep 17 00:00:00 2001 From: jeffrey-signal Date: Wed, 9 Jul 2025 11:46:42 -0400 Subject: [PATCH] Fix crash when attempting to clear pending GlideImage loads. Hold a reference to the Glide RequestManager instead of creating a new instance when attempting to clear pending loads and free resources for the target. --- .../java/org/thoughtcrime/securesms/compose/GlideImage.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/compose/GlideImage.kt b/app/src/main/java/org/thoughtcrime/securesms/compose/GlideImage.kt index 8a9422b049..af374edf68 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/compose/GlideImage.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/compose/GlideImage.kt @@ -114,7 +114,8 @@ private fun GlideImage( val density = LocalDensity.current val context = LocalContext.current DisposableEffect(model, fallback, error, diskCacheStrategy, density, imageSize) { - val builder = Glide.with(context) + val requestManager = Glide.with(context) + val builder = requestManager .load(model) .fallback(fallback) .error(error) @@ -134,7 +135,7 @@ private fun GlideImage( object : DisposableEffectResult { override fun dispose() { - Glide.with(context).clear(target) + requestManager.clear(target) drawable = null } }