From ae923c9221d6ae6cce61974af3a8b5004fe3486f Mon Sep 17 00:00:00 2001 From: Michelle Tang Date: Tue, 13 Aug 2024 11:24:08 -0700 Subject: [PATCH] Remove immediate screen lock option. --- .../settings/app/privacy/PrivacySettingsFragment.kt | 3 ++- .../thoughtcrime/securesms/service/KeyCachingService.java | 6 ++++++ app/src/main/res/values/arrays.xml | 2 -- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/PrivacySettingsFragment.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/PrivacySettingsFragment.kt index 14b1477b82..d45ccde7e3 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/PrivacySettingsFragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/privacy/PrivacySettingsFragment.kt @@ -355,7 +355,8 @@ class PrivacySettingsFragment : DSLSettingsFragment(R.string.preferences__privac return if (!enabledScreenLock) { getString(R.string.ScreenLockSettingsFragment__off) } else if (timeoutSeconds == 0L) { - getString(R.string.ScreenLockSettingsFragment__immediately) + Log.i(TAG, "Default immediate screen lock to one minute") + ExpirationUtil.getExpirationDisplayValue(requireContext(), 60) } else { ExpirationUtil.getExpirationDisplayValue(requireContext(), timeoutSeconds.toInt()) } diff --git a/app/src/main/java/org/thoughtcrime/securesms/service/KeyCachingService.java b/app/src/main/java/org/thoughtcrime/securesms/service/KeyCachingService.java index 54938c5f87..8ae4fde452 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/service/KeyCachingService.java +++ b/app/src/main/java/org/thoughtcrime/securesms/service/KeyCachingService.java @@ -239,6 +239,12 @@ public class KeyCachingService extends Service { boolean screenLockActive = SignalStore.settings().getScreenLockEnabled(); boolean immediateScreenLock = screenTimeout == 0 && screenLockActive; + if (immediateScreenLock) { + Log.i(TAG, "Default immediate screen lock to one minute"); + SignalStore.settings().setScreenLockTimeout(60); + immediateScreenLock = false; + } + if (!appVisible && secretSet && (passLockActive || screenLockActive)) { if (immediateScreenLock) { Log.i(TAG, "Starting immediate screen lock"); diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml index 0e2559eb1a..de04366ca3 100644 --- a/app/src/main/res/values/arrays.xml +++ b/app/src/main/res/values/arrays.xml @@ -363,14 +363,12 @@ - @string/ScreenLockSettingsFragment__immediately @string/ScreenLockSettingsFragment__after_1_min @string/ScreenLockSettingsFragment__after_5_min @string/ScreenLockSettingsFragment__after_30_min - 0 60 300 1800