From b324db53d391567765e578823ea83436f7a86166 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Tue, 18 Oct 2022 09:59:34 -0400 Subject: [PATCH] Fix crash listening to PSTN pickups on some devices. We do this as a helpful thing to end a signal call if the user gets a PSTN call, but some Xiaomi devices are crashing because they require unique permissions. But we can just do it optimistically. --- .../securesms/service/webrtc/WebRtcCallService.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/WebRtcCallService.java b/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/WebRtcCallService.java index 2502250805..779b83b040 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/WebRtcCallService.java +++ b/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/WebRtcCallService.java @@ -131,7 +131,11 @@ public final class WebRtcCallService extends Service implements SignalAudioManag registerNetworkReceiver(); if (!AndroidTelecomUtil.getTelecomSupported()) { - TelephonyUtil.getManager(this).listen(hangUpRtcOnDeviceCallAnswered, PhoneStateListener.LISTEN_CALL_STATE); + try { + TelephonyUtil.getManager(this).listen(hangUpRtcOnDeviceCallAnswered, PhoneStateListener.LISTEN_CALL_STATE); + } catch (SecurityException e) { + Log.w(TAG, "Failed to listen to PSTN call answers!", e); + } } }