Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2025-12-23 20:48:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Force LTR layout in this view because the "playback" button should not be mirrored in RTL.

Browse Source 
In this specific case, the drawable (triangle_right) used in this view
is _not_ autoMirrored which is correct. But the `layout_marginStart`
attribute adds the margin to the wrong side of the view that breaks the
appearance.

c.f. https://material.io/design/usability/bidirectionality.html#mirroring-elements
This commit is contained in:
Fumiaki Yoshimatsu
2021-06-25 16:40:38 -04:00
committed by Alex Hart
parent 615fbf87c9
commit c06056d847
5 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
app/src/main/res/drawable-ldrtl-hdpi/ic_arrow_right.webp Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 168 B

BIN
app/src/main/res/drawable-ldrtl-xhdpi/ic_arrow_right.webp Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 162 B

BIN
app/src/main/res/drawable-ldrtl-xxhdpi/ic_arrow_right.webp Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 190 B

BIN
app/src/main/res/drawable-ldrtl-xxxhdpi/ic_arrow_right.webp Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 196 B

1
app/src/main/res/layout/mediapicker_media_item.xml
View File

@@ -34,6 +34,7 @@
android:layout_marginStart="2dp" android:layout_marginStart="2dp"
android:tint="@color/core_ultramarine" android:tint="@color/core_ultramarine"
android:scaleType="fitXY" android:scaleType="fitXY"
android:layoutDirection="ltr"
app:srcCompat="@drawable/triangle_right" /> app:srcCompat="@drawable/triangle_right" />
</FrameLayout> </FrameLayout>