From c7551881b83b0cfa2df60be5af4ab45a26d1c0c1 Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Wed, 4 Aug 2021 10:36:49 -0400
Subject: [PATCH] Update handling of unrestricted UD access.

---
 .../crypto/UnidentifiedAccessUtil.java        | 22 +++++++++++++------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/crypto/UnidentifiedAccessUtil.java b/app/src/main/java/org/thoughtcrime/securesms/crypto/UnidentifiedAccessUtil.java
index 8f27f614af..90befe887f 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/crypto/UnidentifiedAccessUtil.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/crypto/UnidentifiedAccessUtil.java
@@ -41,6 +41,8 @@ public class UnidentifiedAccessUtil {
 
   private static final String TAG = Log.tag(UnidentifiedAccessUtil.class);
 
+  private static final byte[] UNRESTRICTED_KEY = new byte[16];
+
   public static CertificateValidator getCertificateValidator() {
     try {
       ECPublicKey unidentifiedSenderTrustRoot = Curve.decodePoint(Base64.decode(BuildConfig.UNIDENTIFIED_SENDER_TRUST_ROOT), 0);
@@ -86,7 +88,7 @@ public class UnidentifiedAccessUtil {
     byte[] ourUnidentifiedAccessKey = UnidentifiedAccess.deriveAccessKeyFrom(ProfileKeyUtil.getSelfProfileKey());
 
     if (TextSecurePreferences.isUniversalUnidentifiedAccess(context)) {
-      ourUnidentifiedAccessKey = Util.getSecretBytes(16);
+      ourUnidentifiedAccessKey = UNRESTRICTED_KEY;
     }
 
     List<Optional<UnidentifiedAccessPair>> access = new ArrayList<>(recipients.size());
@@ -133,7 +135,7 @@ public class UnidentifiedAccessUtil {
       byte[] ourUnidentifiedAccessCertificate = getUnidentifiedAccessCertificate(Recipient.self());
 
       if (TextSecurePreferences.isUniversalUnidentifiedAccess(context)) {
-        ourUnidentifiedAccessKey = Util.getSecretBytes(16);
+        ourUnidentifiedAccessKey = UNRESTRICTED_KEY;
       }
 
       if (ourUnidentifiedAccessCertificate != null) {
@@ -171,15 +173,21 @@ public class UnidentifiedAccessUtil {
 
     switch (recipient.resolve().getUnidentifiedAccessMode()) {
       case UNKNOWN:
-        if (theirProfileKey == null) return Util.getSecretBytes(16);
-        else                         return UnidentifiedAccess.deriveAccessKeyFrom(theirProfileKey);
+        if (theirProfileKey == null) {
+          return UNRESTRICTED_KEY;
+        } else {
+          return UnidentifiedAccess.deriveAccessKeyFrom(theirProfileKey);
+        }
       case DISABLED:
         return null;
       case ENABLED:
-        if (theirProfileKey == null) return null;
-        else                         return UnidentifiedAccess.deriveAccessKeyFrom(theirProfileKey);
+        if (theirProfileKey == null) {
+          return null;
+        } else {
+          return UnidentifiedAccess.deriveAccessKeyFrom(theirProfileKey);
+        }
       case UNRESTRICTED:
-        return Util.getSecretBytes(16);
+        return UNRESTRICTED_KEY;
       default:
         throw new AssertionError("Unknown mode: " + recipient.getUnidentifiedAccessMode().getMode());
     }