From c8b7bc2f5be151673bf8faa81882409edec311f9 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Tue, 2 Dec 2025 16:55:30 -0500 Subject: [PATCH] fixup! Fix bug in job eligibility sorting after a job deletion. --- .../securesms/jobs/FastJobStorageTest.kt | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/app/src/test/java/org/thoughtcrime/securesms/jobs/FastJobStorageTest.kt b/app/src/test/java/org/thoughtcrime/securesms/jobs/FastJobStorageTest.kt index 315a4aff7d..64311469ed 100644 --- a/app/src/test/java/org/thoughtcrime/securesms/jobs/FastJobStorageTest.kt +++ b/app/src/test/java/org/thoughtcrime/securesms/jobs/FastJobStorageTest.kt @@ -89,27 +89,6 @@ class FastJobStorageTest { assertThat(subject.getNextEligibleJob(10, NO_PREDICATE)).isEqualTo(fullSpec.jobSpec) } - @Test - fun `insertJobs - depends on memory-only job that does not exist`() { - val database = mockDatabase() - val subject = FastJobStorage(database) - - val dependsOnFullSpec = fullSpec("j1", "f1", isMemoryOnly = true) - - val job = jobSpec("j2", "f2", isMemoryOnly = false) - val dependencySpec = DependencySpec(jobId = "j2", dependsOnJobId = dependsOnFullSpec.jobSpec.id, isMemoryOnly = true) - val fullSpec = FullSpec(jobSpec = job, constraintSpecs = emptyList(), dependencySpecs = listOf(dependencySpec)) - - val fullSpecList = listOf(fullSpec) - subject.insertJobs(fullSpecList) - verify(exactly = 1) { database.insertJobs(fullSpecList) } - - assertThat(subject.getNextEligibleJob(10, NO_PREDICATE)).isEqualTo(dependsOnFullSpec.jobSpec) - subject.deleteJob(dependsOnFullSpec.jobSpec.id) - - assertThat(subject.getNextEligibleJob(10, NO_PREDICATE)).isEqualTo(fullSpec.jobSpec) - } - @Test fun `insertJobs - data can be found`() { val subject = FastJobStorage(mockDatabase())