Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-02-24 03:35:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent crash when subscriber is invoked after view is destroyed.

Browse Source
This commit is contained in:
Alex Hart
2022-07-06 09:45:13 -03:00
parent 78d4d9a3dd
commit c906abdb37
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/org/thoughtcrime/securesms/stories/viewer/page/StoryViewerPageFragment.kt
View File

@@ -31,6 +31,7 @@ import com.google.android.material.button.MaterialButton
import io.reactivex.rxjava3.android.schedulers.AndroidSchedulers
import io.reactivex.rxjava3.core.Observable
import org.signal.core.util.DimensionUnit
import org.signal.core.util.logging.Log
import org.thoughtcrime.securesms.R
import org.thoughtcrime.securesms.components.AvatarImageView
import org.thoughtcrime.securesms.components.segmentedprogressbar.SegmentedProgressBar
@@ -334,6 +335,10 @@ class StoryViewerPageFragment :
return@subscribe
}
if (context == null) {
Log.d(TAG, "Subscriber called while fragment is detached. Ignoring state update.")
}
if (state.posts.isNotEmpty() && state.selectedPostIndex in state.posts.indices) {
val post = state.posts[state.selectedPostIndex]
@@ -936,6 +941,8 @@ class StoryViewerPageFragment :
}
companion object {
private val TAG = Log.tag(StoryViewerPageFragment::class.java)
private val MAX_VIDEO_PLAYBACK_DURATION: Long = TimeUnit.SECONDS.toMillis(30)
private val MIN_GIF_LOOPS: Long = 3L
private val MIN_GIF_PLAYBACK_DURATION = TimeUnit.SECONDS.toMillis(5)