Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-09-22 17:53:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Hide some settings for numberless accounts.

Browse Source
This commit is contained in:
Greyson Parrelli
2026-09-02 16:11:23 -03:00
committed by Alex Hart
parent c4b0f95f72
commit d069ffb6d5
6 changed files with 87 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
feature/app-settings/src/test/java/org/signal/appsettings/account/AccountSettingsScreenTest.kt
+19
View File
@@ -319,6 +319,23 @@ class AccountSettingsScreenTest {
assertThat(events).contains(AccountSettingsEvent.PasskeysClicked)
}
@Test
fun givenAPhoneNumberlessAccount_whenScreenDisplayed_thenPinSectionIsAbsent() {
setContent(createState(isPhoneNumberless = true))
composeTestRule.onNodeWithTag(AccountSettingsTestTags.ROW_MODIFY_PIN).assertDoesNotExist()
composeTestRule.onNodeWithTag(AccountSettingsTestTags.ROW_PIN_REMINDER).assertDoesNotExist()
composeTestRule.onNodeWithTag(AccountSettingsTestTags.ROW_REGISTRATION_LOCK).assertDoesNotExist()
composeTestRule.onNodeWithTag(AccountSettingsTestTags.ROW_ADVANCED_PIN_SETTINGS).assertDoesNotExist()
}
@Test
fun givenAPhoneNumberlessAccount_whenScreenDisplayed_thenChangePhoneNumberIsAbsent() {
setContent(createState(isPhoneNumberless = true))
composeTestRule.onNodeWithTag(AccountSettingsTestTags.ROW_CHANGE_PHONE_NUMBER).assertDoesNotExist()
}
private fun setContent(state: AccountSettingsState) {
composeTestRule.setContent {
AccountSettingsScreen(
@@ -341,6 +358,7 @@ class AccountSettingsScreenTest {
userUnregistered: Boolean = false,
clientDeprecated: Boolean = false,
canTransferWhileUnregistered: Boolean = true,
isPhoneNumberless: Boolean = false,
signalLogin: AccountSettingsState.SignalLogin? = null,
dialog: Dialog = Dialog.None
): AccountSettingsState {
@@ -352,6 +370,7 @@ class AccountSettingsScreenTest {
userUnregistered = userUnregistered,
clientDeprecated = clientDeprecated,
canTransferWhileUnregistered = canTransferWhileUnregistered,
isPhoneNumberless = isPhoneNumberless,
signalLogin = signalLogin,
dialog = dialog
)