From d2cc5d54fedea7972c0665fcaa60298bfdb21a03 Mon Sep 17 00:00:00 2001 From: Cody Henthorne Date: Wed, 26 Mar 2025 13:09:20 -0400 Subject: [PATCH] Use full version code for version tracking. --- .../java/org/thoughtcrime/securesms/AppInitialization.java | 4 ++-- .../thoughtcrime/securesms/util/TextSecurePreferences.java | 3 ++- .../java/org/thoughtcrime/securesms/util/VersionTracker.kt | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/AppInitialization.java b/app/src/main/java/org/thoughtcrime/securesms/AppInitialization.java index 5563a4ed90..20d3e5501b 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/AppInitialization.java +++ b/app/src/main/java/org/thoughtcrime/securesms/AppInitialization.java @@ -32,7 +32,7 @@ public final class AppInitialization { TextSecurePreferences.setAppMigrationVersion(context, ApplicationMigrations.CURRENT_VERSION); TextSecurePreferences.setJobManagerVersion(context, JobManager.CURRENT_VERSION); - TextSecurePreferences.setLastVersionCode(context, Util.getCanonicalVersionCode()); + TextSecurePreferences.setLastVersionCode(context, BuildConfig.VERSION_CODE); TextSecurePreferences.setHasSeenStickerIntroTooltip(context, true); SignalStore.settings().setPassphraseDisabled(true); TextSecurePreferences.setReadReceiptsEnabled(context, true); @@ -72,7 +72,7 @@ public final class AppInitialization { TextSecurePreferences.setAppMigrationVersion(context, ApplicationMigrations.CURRENT_VERSION); TextSecurePreferences.setJobManagerVersion(context, JobManager.CURRENT_VERSION); - TextSecurePreferences.setLastVersionCode(context, Util.getCanonicalVersionCode()); + TextSecurePreferences.setLastVersionCode(context, BuildConfig.VERSION_CODE); TextSecurePreferences.setHasSeenStickerIntroTooltip(context, true); SignalStore.settings().setPassphraseDisabled(true); AppDependencies.getMegaphoneRepository().onFirstEverAppLaunch(); diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/TextSecurePreferences.java b/app/src/main/java/org/thoughtcrime/securesms/util/TextSecurePreferences.java index bf74efa8d5..be120e23fe 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/util/TextSecurePreferences.java +++ b/app/src/main/java/org/thoughtcrime/securesms/util/TextSecurePreferences.java @@ -19,6 +19,7 @@ import org.greenrobot.eventbus.EventBus; import org.signal.core.util.PendingIntentFlags; import org.signal.core.util.logging.Log; import org.signal.libsignal.zkgroup.profiles.ProfileKey; +import org.thoughtcrime.securesms.BuildConfig; import org.thoughtcrime.securesms.R; import org.thoughtcrime.securesms.backup.proto.SharedPreference; import org.thoughtcrime.securesms.crypto.ProfileKeyUtil; @@ -571,7 +572,7 @@ public class TextSecurePreferences { } public static int getLastVersionCode(Context context) { - return getIntegerPreference(context, LAST_VERSION_CODE_PREF, Util.getCanonicalVersionCode()); + return getIntegerPreference(context, LAST_VERSION_CODE_PREF, BuildConfig.VERSION_CODE); } public static void setLastVersionCode(Context context, int versionCode) { diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/VersionTracker.kt b/app/src/main/java/org/thoughtcrime/securesms/util/VersionTracker.kt index 1f57500f18..24fb0fe063 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/util/VersionTracker.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/util/VersionTracker.kt @@ -3,6 +3,7 @@ package org.thoughtcrime.securesms.util import android.content.Context import android.content.pm.PackageManager import org.signal.core.util.logging.Log +import org.thoughtcrime.securesms.BuildConfig import org.thoughtcrime.securesms.dependencies.AppDependencies import org.thoughtcrime.securesms.jobs.RefreshAttributesJob import org.thoughtcrime.securesms.jobs.RemoteConfigRefreshJob @@ -20,7 +21,7 @@ object VersionTracker { @JvmStatic fun updateLastSeenVersion(context: Context) { - val currentVersionCode = Util.getCanonicalVersionCode() + val currentVersionCode = BuildConfig.VERSION_CODE val lastVersionCode = TextSecurePreferences.getLastVersionCode(context) if (currentVersionCode != lastVersionCode) {