Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-25 11:20:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename FeatureFlags -> RemoteConfig.

Browse Source
This commit is contained in:
Greyson Parrelli
2024-06-12 14:58:39 -04:00
parent ecbea9fd95
commit d698f74d0b
136 changed files with 460 additions and 478 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/test/java/org/thoughtcrime/securesms/util/LocaleFeatureFlagsTest_getCountryValue.java → app/src/test/java/org/thoughtcrime/securesms/util/LocaleRemoteConfigTest_getCountryValue.java
View File

@@ -17,7 +17,7 @@ import java.util.Map;
import static org.junit.Assert.assertEquals;
@RunWith(Parameterized.class)
public class LocaleFeatureFlagsTest_getCountryValue {
public class LocaleRemoteConfigTest_getCountryValue {
private final String phoneNumber;
private final Map<String, Integer> countryCounts;
@@ -66,7 +66,7 @@ public class LocaleFeatureFlagsTest_getCountryValue {
Log.initialize(new EmptyLogger());
}
public LocaleFeatureFlagsTest_getCountryValue(@NonNull String phoneNumber,
public LocaleRemoteConfigTest_getCountryValue(@NonNull String phoneNumber,
@NonNull Map<String, Integer> countryCounts,
long output)
{
@@ -77,7 +77,7 @@ public class LocaleFeatureFlagsTest_getCountryValue {
@Test
public void determineCountEnabled() {
assertEquals(output, LocaleFeatureFlags.getCountryValue(countryCounts, phoneNumber, 0));
assertEquals(output, LocaleRemoteConfig.getCountryValue(countryCounts, phoneNumber, 0));
}
}

6
app/src/test/java/org/thoughtcrime/securesms/util/LocaleFeatureFlagsTest_parseCountryValues.java → app/src/test/java/org/thoughtcrime/securesms/util/LocaleRemoteConfigTest_parseCountryValues.java
View File

@@ -12,7 +12,7 @@ import java.util.Map;
import static org.junit.Assert.assertEquals;
@RunWith(Parameterized.class)
public class LocaleFeatureFlagsTest_parseCountryValues {
public class LocaleRemoteConfigTest_parseCountryValues {
private final String input;
private final Map<String, Integer> output;
@@ -46,14 +46,14 @@ public class LocaleFeatureFlagsTest_parseCountryValues {
});
}
public LocaleFeatureFlagsTest_parseCountryValues(String input, Map<String, Integer> output) {
public LocaleRemoteConfigTest_parseCountryValues(String input, Map<String, Integer> output) {
this.input = input;
this.output = output;
}
@Test
public void parseCountryCounts() {
assertEquals(output, LocaleFeatureFlags.parseCountryValues(input, 0));
assertEquals(output, LocaleRemoteConfig.parseCountryValues(input, 0));
}
}

4
app/src/test/java/org/thoughtcrime/securesms/util/LocaleFeatureFlags_isEnabled.kt → app/src/test/java/org/thoughtcrime/securesms/util/LocaleRemoteConfig_isEnabled.kt
View File

@@ -11,12 +11,12 @@ import org.junit.runners.Parameterized
import org.thoughtcrime.securesms.assertIs
@RunWith(Parameterized::class)
class LocaleFeatureFlags_isEnabled(private val serializedList: String, private val e164: List<String>, private val output: Boolean) {
class LocaleRemoteConfig_isEnabled(private val serializedList: String, private val e164: List<String>, private val output: Boolean) {
@Test
fun isLegal() {
e164.forEach {
LocaleFeatureFlags.isEnabledE164Start(serializedList, it) assertIs output
LocaleRemoteConfig.isEnabledE164Start(serializedList, it) assertIs output
}
}

62
app/src/test/java/org/thoughtcrime/securesms/util/FeatureFlagsTest.java → app/src/test/java/org/thoughtcrime/securesms/util/RemoteConfigTest.java
View File

@@ -2,8 +2,8 @@ package org.thoughtcrime.securesms.util;
import org.junit.Test;
import org.thoughtcrime.securesms.BaseUnitTest;
import org.thoughtcrime.securesms.util.FeatureFlags.ConfigChange;
import org.thoughtcrime.securesms.util.FeatureFlags.UpdateResult;
import org.thoughtcrime.securesms.util.RemoteConfig.ConfigChange;
import org.thoughtcrime.securesms.util.RemoteConfig.UpdateResult;
import java.util.Arrays;
import java.util.HashMap;
@@ -16,14 +16,14 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.thoughtcrime.securesms.testutil.TestHelpers.mapOf;
public class FeatureFlagsTest extends BaseUnitTest {
public class RemoteConfigTest extends BaseUnitTest {
private static final String A = "A";
private static final String B = "B";
@Test
public void updateInternal_newValue_ignoreNotInRemoteCapable() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true,
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true,
B, true),
mapOf(),
mapOf(),
@@ -38,7 +38,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_newValue() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(),
mapOf(),
setOf(A),
@@ -52,7 +52,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_newValue_hotSwap() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(),
mapOf(),
setOf(A),
@@ -66,7 +66,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_newValue_hotSwap_integer() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, 1),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, 1),
mapOf(),
mapOf(),
setOf(A),
@@ -80,7 +80,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_newValue_sticky() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(),
mapOf(),
setOf(A),
@@ -94,7 +94,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_newValue_hotSwap_sticky() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(),
mapOf(),
setOf(A),
@@ -108,7 +108,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceValue() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, false),
mapOf(A, false),
setOf(A),
@@ -122,7 +122,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceValue_integer() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, 2),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, 2),
mapOf(A, 1),
mapOf(A, 1),
setOf(A),
@@ -136,7 +136,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceValue_hotSwap() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, false),
mapOf(A, false),
setOf(A),
@@ -150,7 +150,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceValue_hotSwa_integer() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, 2),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, 2),
mapOf(A, 1),
mapOf(A, 1),
setOf(A),
@@ -164,7 +164,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceValue_hotSwap_stickyChange() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, false),
mapOf(A, false),
setOf(A),
@@ -178,7 +178,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceValue_hotSwap_stickyIgnore_memoryAndDisk() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, false),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, false),
mapOf(A, true),
mapOf(A, true),
setOf(A),
@@ -192,7 +192,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(),
mapOf(A, true),
mapOf(A, true),
setOf(A),
@@ -206,7 +206,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_notRemoteCapable() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, true),
mapOf(A, true),
setOf(),
@@ -220,7 +220,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_hotSwap() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(),
mapOf(A, true),
mapOf(A, true),
setOf(A),
@@ -234,7 +234,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_hotSwap_notRemoteCapable() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, true),
mapOf(A, true),
setOf(),
@@ -248,7 +248,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_stickyAlreadyEnabled() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(),
mapOf(A, true),
mapOf(A, true),
setOf(A),
@@ -262,7 +262,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_stickyNotEnabled() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(),
mapOf(A, false),
mapOf(A, false),
setOf(A),
@@ -276,7 +276,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_stickyNotEnabled_notRemoteCapable() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, false),
mapOf(A, false),
setOf(),
@@ -290,7 +290,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_hotSwap_stickyAlreadyEnabled() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(),
mapOf(A, true),
mapOf(A, true),
setOf(A),
@@ -304,7 +304,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_hotSwap_stickyAlreadyEnabled_notRemoteCapable() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true),
mapOf(A, true),
mapOf(A, true),
setOf(),
@@ -318,7 +318,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_hotSwap_stickyNotEnabled() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(),
mapOf(A, false),
mapOf(A, false),
setOf(A),
@@ -332,7 +332,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_removeValue_typeMismatch_hotSwap() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, "5"),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, "5"),
mapOf(A, true),
mapOf(A, true),
setOf(A),
@@ -346,9 +346,9 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_twoNewValues() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true,
B, false),
mapOf(),
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true,
B, false),
mapOf(),
mapOf(),
setOf(A, B),
setOf(),
@@ -361,7 +361,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
@Test
public void updateInternal_replaceOneOfTwoValues() {
UpdateResult result = FeatureFlags.updateInternal(mapOf(A, true,
UpdateResult result = RemoteConfig.updateInternal(mapOf(A, true,
B, false),
mapOf(A, true,
B, true),
@@ -400,7 +400,7 @@ public class FeatureFlagsTest extends BaseUnitTest {
put("j", "stacy");
}};
Map<String, ConfigChange> changes = FeatureFlags.computeChanges(oldMap, newMap);
Map<String, ConfigChange> changes = RemoteConfig.computeChanges(oldMap, newMap);
assertFalse(changes.containsKey("a"));
assertEquals(new ConfigChange(false, true), changes.get("b"));

10
app/src/test/java/org/thoughtcrime/securesms/util/FeatureFlags_StaticValuesTest.kt → app/src/test/java/org/thoughtcrime/securesms/util/RemoteConfig_StaticValuesTest.kt
View File

@@ -8,7 +8,7 @@ import kotlin.reflect.full.memberProperties
/**
* Ensures we don't release with forced values which is intended for local development only.
*/
class FeatureFlags_StaticValuesTest {
class RemoteConfig_StaticValuesTest {
/**
* This test cycles the REMOTE_VALUES through a bunch of different inputs, then looks at all of the public getters and checks to see if they return different
@@ -31,7 +31,7 @@ class FeatureFlags_StaticValuesTest {
"*"
)
val configKeys = FeatureFlags.configsByKey.keys
val configKeys = RemoteConfig.configsByKey.keys
val ignoreList = setOf(
"REMOTE_VALUES",
@@ -44,7 +44,7 @@ class FeatureFlags_StaticValuesTest {
"PROMPT_FOR_NOTIFICATION_LOGS"
)
val publicVals: List<KProperty1<*, *>> = FeatureFlags::class.memberProperties
val publicVals: List<KProperty1<*, *>> = RemoteConfig::class.memberProperties
.filter { it.visibility == KVisibility.PUBLIC }
.filterNot { ignoreList.contains(it.name) }
@@ -52,11 +52,11 @@ class FeatureFlags_StaticValuesTest {
for (input in remoteTestInputs) {
for (key in configKeys) {
FeatureFlags.REMOTE_VALUES[key] = input
RemoteConfig.REMOTE_VALUES[key] = input
}
for (publicVal in publicVals) {
val output: Any? = publicVal.getter.call(FeatureFlags)
val output: Any? = publicVal.getter.call(RemoteConfig)
val existingOutputs: MutableSet<Any?> = publicValOutputs.getOrDefault(publicVal.name, mutableSetOf())
existingOutputs.add(output)
publicValOutputs[publicVal.name] = existingOutputs