Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-02-24 11:45:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not attempt to re-upload known-bad backup files.

Browse Source
This commit is contained in:
Greyson Parrelli
2025-10-27 12:05:19 -04:00
committed by jeffrey-signal
parent 9ddc914cac
commit e288b8b429
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/thoughtcrime/securesms/jobs/BackupMessagesJob.kt
View File

@@ -235,6 +235,8 @@ class BackupMessagesJob private constructor(
when (result.code) {
413 -> {
Log.i(TAG, "Backup file is too large! Size: ${tempBackupFile.length()} bytes", result.getCause(), true)
tempBackupFile.delete()
this.dataFile = ""
// TODO [backup] Need to show the user an error
}
else -> {
@@ -410,6 +412,8 @@ class BackupMessagesJob private constructor(
is ArchiveValidator.ValidationResult.MessageValidationError -> {
Log.w(TAG, "The backup file fails validation! Message: ${result.exception.message}, Details: ${result.messageDetails}", true)
tempBackupFile.delete()
this.dataFile = ""
SignalStore.backup.hasValidationError = true
ArchiveUploadProgress.onValidationFailure()
return BackupFileResult.Failure
@@ -417,6 +421,8 @@ class BackupMessagesJob private constructor(
is ArchiveValidator.ValidationResult.RecipientDuplicateE164Error -> {
Log.w(TAG, "The backup file fails validation with a duplicate recipient! Message: ${result.exception.message}, Details: ${result.details}", true)
tempBackupFile.delete()
this.dataFile = ""
AppDependencies.jobManager.add(E164FormattingJob())
SignalStore.backup.hasValidationError = true
ArchiveUploadProgress.onValidationFailure()