From e2dc7fb5bf5a55e2a493c8b1042e1e69b503d8fd Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Tue, 9 Nov 2021 10:35:45 -0500 Subject: [PATCH] Fix early close when navigating back to camera-first capture. Fixes #11729 --- .../securesms/mediasend/v2/MediaSelectionViewModel.kt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionViewModel.kt b/app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionViewModel.kt index 7ba4eb903e..ebe1210e50 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionViewModel.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionViewModel.kt @@ -179,6 +179,10 @@ class MediaSelectionViewModel( } fun removeMedia(media: Media) { + removeMedia(media, false) + } + + private fun removeMedia(media: Media, suppressEmptyError: Boolean) { val snapshot = store.state val newMediaList = snapshot.selectedMedia - media val oldFocusIndex = snapshot.selectedMedia.indexOf(media) @@ -197,7 +201,7 @@ class MediaSelectionViewModel( ) } - if (newMediaList.isEmpty()) { + if (newMediaList.isEmpty() && !suppressEmptyError) { mediaErrors.postValue(MediaValidator.FilterError.NO_ITEMS) } @@ -216,7 +220,7 @@ class MediaSelectionViewModel( fun removeCameraFirstCapture() { val cameraFirstCapture: Media? = store.state.cameraFirstCapture if (cameraFirstCapture != null) { - removeMedia(cameraFirstCapture) + removeMedia(cameraFirstCapture, true) } }