Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-02-22 02:36:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove story text posts feature flag.

Browse Source
This commit is contained in:
Alex Hart
2022-05-05 12:18:20 -03:00
parent 4b8729c2ae
commit e770241ed4
4 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/thoughtcrime/securesms/mediasend/Camera1Fragment.java
View File

@@ -283,7 +283,7 @@ public class Camera1Fragment extends LoggingFragment implements CameraFragment,
View toggleSpacer = requireView().findViewById(R.id.toggle_spacer);
if (toggleSpacer != null) {
if (Stories.isFeatureEnabled() && FeatureFlags.storiesTextPosts()) {
if (Stories.isFeatureEnabled()) {
StoryDisplay storyDisplay = StoryDisplay.Companion.getStoryDisplay(getResources().getDisplayMetrics().widthPixels, getResources().getDisplayMetrics().heightPixels);
if (storyDisplay == StoryDisplay.SMALL) {
toggleSpacer.setVisibility(View.VISIBLE);

2
app/src/main/java/org/thoughtcrime/securesms/mediasend/CameraXFragment.java
View File

@@ -260,7 +260,7 @@ public class CameraXFragment extends LoggingFragment implements CameraFragment {
View toggleSpacer = requireView().findViewById(R.id.toggle_spacer);
if (toggleSpacer != null) {
if ( Stories.isFeatureEnabled() && FeatureFlags.storiesTextPosts()) {
if ( Stories.isFeatureEnabled()) {
StoryDisplay storyDisplay = StoryDisplay.Companion.getStoryDisplay(getResources().getDisplayMetrics().widthPixels, getResources().getDisplayMetrics().heightPixels);
if (storyDisplay == StoryDisplay.SMALL) {
toggleSpacer.setVisibility(View.VISIBLE);

2
app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionActivity.kt
View File

@@ -42,7 +42,6 @@ import org.thoughtcrime.securesms.mediasend.v2.text.TextStoryPostCreationViewMod
import org.thoughtcrime.securesms.mediasend.v2.text.send.TextStoryPostSendRepository
import org.thoughtcrime.securesms.recipients.RecipientId
import org.thoughtcrime.securesms.stories.Stories
import org.thoughtcrime.securesms.util.FeatureFlags
import org.thoughtcrime.securesms.util.navigation.safeNavigate
import org.thoughtcrime.securesms.util.visible
@@ -209,7 +208,6 @@ class MediaSelectionActivity :
private fun canDisplayStorySwitch(): Boolean {
return Stories.isFeatureEnabled() &&
FeatureFlags.storiesTextPosts() &&
isCameraFirst() &&
!viewModel.hasSelectedMedia() &&
destination == MediaSelectionDestination.ChooseAfterMediaSelection

11
app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java
View File

@@ -89,7 +89,6 @@ public final class FeatureFlags {
private static final String CDSH = "android.cdsh";
private static final String STORIES = "android.stories.2";
private static final String STORIES_TEXT_FUNCTIONS = "android.stories.text.functions";
private static final String STORIES_TEXT_POSTS = "android.stories.text.posts.2";
private static final String HARDWARE_AEC_BLOCKLIST_MODELS = "android.calling.hardwareAecBlockList";
private static final String SOFTWARE_AEC_BLOCKLIST_MODELS = "android.calling.softwareAecBlockList";
private static final String USE_HARDWARE_AEC_IF_OLD = "android.calling.useHardwareAecIfOlderThanApi29";
@@ -141,7 +140,6 @@ public final class FeatureFlags {
DONOR_BADGES_DISPLAY,
STORIES,
STORIES_TEXT_FUNCTIONS,
STORIES_TEXT_POSTS,
HARDWARE_AEC_BLOCKLIST_MODELS,
SOFTWARE_AEC_BLOCKLIST_MODELS,
USE_HARDWARE_AEC_IF_OLD,
@@ -464,15 +462,6 @@ public final class FeatureFlags {
return getBoolean(STORIES_TEXT_FUNCTIONS, false);
}
/**
* Whether the user supports sending Story text posts
*
* NOTE: This feature is still under ongoing development, do not enable.
*/
public static boolean storiesTextPosts() {
return getBoolean(STORIES_TEXT_POSTS, false);
}
/**
* Whether or not donor badges should be displayed throughout the app.
*/