Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-02-23 19:26:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add chat folder support to storage service.

Browse Source
This commit is contained in:
Michelle Tang
2025-04-04 11:36:17 -04:00
parent f6ecb572b1
commit eb1cf8d62f
26 changed files with 1131 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

216
app/src/test/java/org/thoughtcrime/securesms/storage/ChatFolderRecordProcessorTest.kt Normal file
View File

@@ -0,0 +1,216 @@
package org.thoughtcrime.securesms.storage
import okio.ByteString.Companion.toByteString
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.junit.BeforeClass
import org.junit.Test
import org.signal.core.util.logging.Log
import org.thoughtcrime.securesms.testutil.EmptyLogger
import org.whispersystems.signalservice.api.storage.SignalChatFolderRecord
import org.whispersystems.signalservice.api.storage.StorageId
import org.whispersystems.signalservice.api.util.UuidUtil
import org.whispersystems.signalservice.internal.storage.protos.ChatFolderRecord
import java.util.UUID
/**
* Tests for [ChatFolderRecordProcessor]
*/
class ChatFolderRecordProcessorTest {
companion object {
val STORAGE_ID: StorageId = StorageId.forChatFolder(byteArrayOf(1, 2, 3, 4))
@JvmStatic
@BeforeClass
fun setUpClass() {
Log.initialize(EmptyLogger())
}
}
private val testSubject = ChatFolderRecordProcessor()
@Test
fun `Given a valid proto with a known name and folder type, assert valid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = "Folder1"
position = 1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 0L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertFalse(result)
}
@Test
fun `Given an invalid proto with no name, assert invalid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = ""
position = 1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 0L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertTrue(result)
}
@Test
fun `Given a valid proto with no folder type, assert invalid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = "Folder1"
position = 1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.UNKNOWN
deletedAtTimestampMs = 0L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertTrue(result)
}
@Test
fun `Given a valid proto with a deleted timestamp and negative position, assert valid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = "Folder1"
position = -1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 100L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertFalse(result)
}
@Test
fun `Given an invalid proto with a deleted timestamp and positive position, assert invalid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = "Folder1"
position = 1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 100L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertTrue(result)
}
@Test
fun `Given an invalid proto with a negative position, assert invalid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = "Folder1"
position = -1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 0L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertTrue(result)
}
@Test
fun `Given an invalid proto with a bad id, assert invalid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = "bad".toByteArray().toByteString()
name = "Folder1"
position = -1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 0L
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertTrue(result)
}
@Test
fun `Given an invalid proto with a bad recipient, assert invalid`() {
// GIVEN
val proto = ChatFolderRecord.Builder().apply {
identifier = UuidUtil.toByteArray(UUID.randomUUID()).toByteString()
name = "Folder1"
position = -1
showOnlyUnread = false
showMutedChats = false
includeAllIndividualChats = false
includeAllGroupChats = false
folderType = ChatFolderRecord.FolderType.CUSTOM
deletedAtTimestampMs = 0L
includedRecipients = listOf(ChatFolderRecord.Recipient(contact = ChatFolderRecord.Recipient.Contact(serviceId = "bad")))
}.build()
val record = SignalChatFolderRecord(STORAGE_ID, proto)
// WHEN
val result = testSubject.isInvalid(record)
// THEN
assertTrue(result)
}
}