From ed25be2e23e19dd23349801089f864e4eaef05de Mon Sep 17 00:00:00 2001 From: Cody Henthorne Date: Mon, 27 Jun 2022 11:22:46 -0400 Subject: [PATCH] Fix couple more places where Note to Self should be used. --- .../settings/conversation/ConversationSettingsFragment.kt | 2 +- .../securesms/components/voice/VoiceNoteMediaItemFactory.java | 3 ++- app/src/main/res/layout/conversation_settings_toolbar.xml | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/conversation/ConversationSettingsFragment.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/conversation/ConversationSettingsFragment.kt index 6584b237d5..eaf9e6898a 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/conversation/ConversationSettingsFragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/conversation/ConversationSettingsFragment.kt @@ -235,7 +235,7 @@ class ConversationSettingsFragment : DSLSettingsFragment( } state.withRecipientSettingsState { - toolbarTitle.text = state.recipient.getDisplayName(requireContext()) + toolbarTitle.text = if (state.recipient.isSelf) getString(R.string.note_to_self) else state.recipient.getDisplayName(requireContext()) } state.withGroupSettingsState { diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNoteMediaItemFactory.java b/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNoteMediaItemFactory.java index 93fe8b15ed..8af4401ef0 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNoteMediaItemFactory.java +++ b/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNoteMediaItemFactory.java @@ -175,7 +175,8 @@ class VoiceNoteMediaItemFactory { sender.getDisplayName(context), threadRecipient.getDisplayName(context)); } else if (preference.isDisplayContact()) { - return sender.getDisplayName(context); + return sender.isSelf() ? context.getString(R.string.note_to_self) + : sender.getDisplayName(context); } else { return context.getString(R.string.MessageNotifier_signal_message); } diff --git a/app/src/main/res/layout/conversation_settings_toolbar.xml b/app/src/main/res/layout/conversation_settings_toolbar.xml index 998ad7d9f3..141ed548df 100644 --- a/app/src/main/res/layout/conversation_settings_toolbar.xml +++ b/app/src/main/res/layout/conversation_settings_toolbar.xml @@ -61,10 +61,10 @@ android:id="@+id/toolbar_title" android:layout_width="wrap_content" android:layout_height="wrap_content" + android:layout_gravity="center_vertical" android:layout_marginStart="16dp" android:alpha="0" android:ellipsize="end" - android:gravity="center_vertical" android:maxLines="1" android:textAppearance="@style/Signal.Text.TitleLarge" android:translationY="56dp"