Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2025-12-22 12:08:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Protect against individual item updates being put into an invalidated list.

Browse Source
This commit is contained in:
Greyson Parrelli
2021-11-22 10:40:06 -05:00
parent 1a9d785cbb
commit ef7d5d55cb
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
paging/lib/src/main/java/org/signal/paging/FixedSizePagingController.java
View File

@@ -142,6 +142,11 @@ class FixedSizePagingController<Key, Data> implements PagingController<Key> {
return; return;
} }
if (invalidated) {
Log.w(TAG, "Invalidated! Just before individual change was loaded for position " + position);
return;
}
Data item = dataSource.load(key); Data item = dataSource.load(key);
if (item == null) { if (item == null) {
@@ -149,6 +154,11 @@ class FixedSizePagingController<Key, Data> implements PagingController<Key> {
return; return;
} }
if (invalidated) {
Log.w(TAG, "Invalidated! Just after individual change was loaded for position " + position);
return;
}
List<Data> updatedList = new CompressedList<>(data); List<Data> updatedList = new CompressedList<>(data);
updatedList.set(position, item); updatedList.set(position, item);
@@ -165,6 +175,11 @@ class FixedSizePagingController<Key, Data> implements PagingController<Key> {
return; return;
} }
if (invalidated) {
Log.w(TAG, "Invalidated! Just before individual insert was loaded for position " + position);
return;
}
Data item = dataSource.load(key); Data item = dataSource.load(key);
if (item == null) { if (item == null) {
@@ -172,6 +187,11 @@ class FixedSizePagingController<Key, Data> implements PagingController<Key> {
return; return;
} }
if (invalidated) {
Log.w(TAG, "Invalidated! Just after individual insert was loaded for position " + position);
return;
}
List<Data> updatedList = new CompressedList<>(data); List<Data> updatedList = new CompressedList<>(data);
updatedList.add(position, item); updatedList.add(position, item);