Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-20 08:39:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve handling of errors when saving media attachments.

Browse Source 
Improves the error handling in `SaveAttachmentUtil.saveAttachments()` to continue processing all requested attachment saves even after individual save operations fail.
This commit is contained in:
Jeffrey Starke
2025-03-10 13:50:40 -04:00
committed by Greyson Parrelli
parent 9b6f355802
commit f2950e279b
4 changed files with 118 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
app/src/main/res/values/strings.xml
View File

@@ -573,11 +573,6 @@
<item quantity="one">Saving this media to storage will allow any other apps on your device to access it.\n\nContinue?</item>
<item quantity="other">Saving all %1$d media to storage will allow any other apps on your device to access them.\n\nContinue?</item>
</plurals>
<plurals name="ConversationFragment_error_while_saving_attachments_to_sd_card">
<item quantity="one">Error while saving attachment to storage!</item>
<item quantity="other">Error while saving attachments to storage!</item>
</plurals>
<string name="ConversationFragment_unable_to_write_to_sd_card_exclamation">Unable to write to storage!</string>
<plurals name="ConversationFragment_saving_n_attachments">
<item quantity="one">Saving attachment</item>
<item quantity="other">Saving %1$d attachments</item>
@@ -3083,8 +3078,27 @@
<string name="QuickResponseService_quick_response_unavailable_when_Signal_is_locked">Quick response unavailable when Signal is locked!</string>
<string name="QuickResponseService_problem_sending_message">Problem sending message!</string>
<!-- A small toast notification to let the user know their image/video/audio was downloaded and saved to their device, accessible in other apps. -->
<string name="SaveAttachmentTask_saved">Media saved</string>
<!-- A toast notification that is shown when the app does not have sufficient permissions to save media files to the device storage. -->
<string name="SaveAttachment_unable_to_write_to_sd_card_exclamation">Unable to write to storage!</string>
<!-- A toast notification that is shown after image/video/audio media was successfully downloaded and saved to the device storage, accessible in other apps. -->
<plurals name="SaveAttachment_saved_success">
<item quantity="one">Media saved</item>
<item quantity="other">Media saved</item>
</plurals>
<!-- A toast notification that is shown after some image/video/audio media was successfully downloaded and saved to the device storage, but some failed to save
%1$s is the number of items that failed to save and %2$s is the total number of items that the user requested to save. -->
<plurals name="SaveAttachment_saved_success_n_failures">
<item quantity="one">Media saved (%1$s of %2$s failed)</item>
<item quantity="other">Media saved (%1$s of %2$s failed)</item>
</plurals>
<!-- A toast notification that is shown after all of the requested image/video/audio media failed to save to the device storage. -->
<plurals name="SaveAttachment_error_while_saving_attachments_to_sd_card">
<item quantity="one">Error while saving attachment to storage!</item>
<item quantity="other">Error while saving attachments to storage!</item>
</plurals>
<!-- SearchToolbar -->
<string name="SearchToolbar_search">Search</string>