From fe20de29956880dcc1008d495c26c47ef6ffd605 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Thu, 29 Jun 2023 15:55:12 -0400 Subject: [PATCH] Improve logging around edit and sync messages. --- .../org/thoughtcrime/securesms/jobs/IndividualSendJob.java | 2 +- .../signalservice/api/SignalServiceMessageSender.java | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/jobs/IndividualSendJob.java b/app/src/main/java/org/thoughtcrime/securesms/jobs/IndividualSendJob.java index a8b0ebb8d9..4a28df02be 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/jobs/IndividualSendJob.java +++ b/app/src/main/java/org/thoughtcrime/securesms/jobs/IndividualSendJob.java @@ -153,7 +153,7 @@ public class IndividualSendJob extends PushSendJob { } try { - log(TAG, String.valueOf(message.getSentTimeMillis()), "Sending message: " + messageId + ", Recipient: " + message.getThreadRecipient().getId() + ", Thread: " + threadId + ", Attachments: " + buildAttachmentString(message.getAttachments())); + log(TAG, String.valueOf(message.getSentTimeMillis()), "Sending message: " + messageId + ", Recipient: " + message.getThreadRecipient().getId() + ", Thread: " + threadId + ", Attachments: " + buildAttachmentString(message.getAttachments()) + ", Editing: " + (originalEditedMessage != null ? originalEditedMessage.getDateSent() : "N/A")); RecipientUtil.shareProfileIfFirstSecureMessage(message.getThreadRecipient()); diff --git a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java index 5cdecf3fdc..8170f82690 100644 --- a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java +++ b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java @@ -439,7 +439,7 @@ public class SignalServiceMessageSender { long targetSentTimestamp) throws UntrustedIdentityException, IOException { - Log.d(TAG, "[" + message.getTimestamp() + "] Sending an edit message."); + Log.d(TAG, "[" + message.getTimestamp() + "] Sending an edit message for " + targetSentTimestamp + "."); Content content = createEditMessageContent(new SignalServiceEditMessage(targetSentTimestamp, message)); @@ -642,12 +642,14 @@ public class SignalServiceMessageSender { public SendMessageResult sendSyncMessage(SignalServiceDataMessage dataMessage) throws IOException, UntrustedIdentityException { + Log.d(TAG, "[" + dataMessage.getTimestamp() + "] Sending self-sync message."); return sendSyncMessage(createSelfSendSyncMessage(dataMessage), Optional.empty()); } public SendMessageResult sendSelfSyncEditMessage(SignalServiceEditMessage editMessage) throws IOException, UntrustedIdentityException { + Log.d(TAG, "[" + editMessage.getDataMessage().getTimestamp() + "] Sending self-sync edit message for " + editMessage.getTargetSentTimestamp() + "."); return sendSyncMessage(createSelfSendSyncEditMessage(editMessage), Optional.empty()); }