Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 12:19:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename Whisper.View#attributes

Browse Source 
Avoid colliding with Backbone.View attributes, which is a list of attrs
to set on the html element for a view.
This commit is contained in:
lilia
2015-03-06 17:05:36 -08:00
parent dc1b09f59d
commit 1321a90667
6 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/views/whisper_view_test.js
View File

@@ -1,8 +1,8 @@
describe('Whisper.View', function() {
it('renders a template with attributes', function() {
it('renders a template with render_attributes', function() {
var viewClass = Whisper.View.extend({
template: '<div>{{ variable }}</div>',
attributes: {
render_attributes: {
variable: 'value'
}
});
@@ -11,7 +11,7 @@ describe('Whisper.View', function() {
view.render();
assert.strictEqual(view.$el.html(), '<div>value</div>');
});
it('renders a template with no attributes', function() {
it('renders a template with no render_attributes', function() {
var viewClass = Whisper.View.extend({
template: '<div>static text</div>'
});
@@ -20,10 +20,10 @@ describe('Whisper.View', function() {
view.render();
assert.strictEqual(view.$el.html(), '<div>static text</div>');
});
it('renders a template function with attributes function', function() {
it('renders a template function with render_attributes function', function() {
var viewClass = Whisper.View.extend({
template: function() { return '<div>{{ variable }}</div>'; },
attributes: function() {
render_attributes: function() {
return { variable: 'value' };
}
});