Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-20 00:18:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use a node-gyp version which supports Python3

Browse Source 
The currently pinned version of `node-gyp` requires Python 2.  Python 2
has reached its EOL a long time ago and is unsupported by upstream.

The requirement on Python 2 is also an unnecessary barrier for new
developers to contribute to Signal.

This changeset updates the required version of node-gyp to one
compatible with Python 3.

`CONTRIBUTING.md` remains unchanged, since this dependency was not
previously mentioned anyway.

Supersedes #4407
Fixes #4783
This commit is contained in:
Hugo Osvaldo Barrera
2021-01-11 10:57:53 +01:00
parent fbaf3ba247
commit 207c533de1
3 changed files with 22 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ts/util/lint/exceptions.json
View File

@@ -10264,7 +10264,7 @@
"rule": "jQuery-$(",
"path": "node_modules/node-gyp/lib/configure.js",
"line": " !gyp.opts.nodedir ? '<(target_arch)' : '$(Configuration)',",
"lineNumber": 299,
"lineNumber": 300,
"reasonCategory": "falseMatch",
"updated": "2019-07-19T17:16:02.404Z"
},