Remove invalid quotes from conversation

This commit is contained in:
trevor-signal
2025-10-24 12:53:59 -04:00
committed by GitHub
parent fb566c48e0
commit 2ad2907cf9

View File

@@ -733,19 +733,20 @@ export function setQuoteByMessageId(
const message = messageId ? await getMessageById(messageId) : undefined; const message = messageId ? await getMessageById(messageId) : undefined;
const state = getState(); const state = getState();
if ( if (
message && !message ||
!isNormalBubble(message.attributes) ||
!canReply( !canReply(
message.attributes, message.attributes,
window.ConversationController.getOurConversationIdOrThrow(), window.ConversationController.getOurConversationIdOrThrow(),
getConversationSelector(state) getConversationSelector(state)
) )
) { ) {
return; dispatch(setQuotedMessage(conversationId, undefined));
} conversation.set({
quotedMessageId: undefined,
if (message && !isNormalBubble(message.attributes)) { });
await DataWriter.updateConversation(conversation.attributes);
return; return;
} }
@@ -770,25 +771,21 @@ export function setQuoteByMessageId(
await DataWriter.updateConversation(conversation.attributes); await DataWriter.updateConversation(conversation.attributes);
} }
if (message) { const quote = await makeQuote(message.attributes);
const quote = await makeQuote(message.attributes);
// In case the conversation changed while we were about to set the quote // In case the conversation changed while we were about to set the quote
if (getState().conversations.selectedConversationId !== conversationId) { if (getState().conversations.selectedConversationId !== conversationId) {
return; return;
}
dispatch(
setQuotedMessage(conversationId, {
conversationId,
quote,
})
);
dispatch(setComposerFocus(conversation.id));
} else {
dispatch(setQuotedMessage(conversationId, undefined));
} }
dispatch(
setQuotedMessage(conversationId, {
conversationId,
quote,
})
);
dispatch(setComposerFocus(conversation.id));
}; };
} }