Update all type methods to use property syntax

Co-authored-by: Jamie <113370520+jamiebuilds-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2026-05-26 15:52:29 -05:00
committed by GitHub
parent 8a0677572c
commit 2b1952ded3
53 changed files with 295 additions and 283 deletions
+103 -101
View File
@@ -921,13 +921,13 @@ type ReadableInterface = {
includeStoryReplies: boolean;
}
) => number;
getOldestUnreadMentionOfMeForConversation(
getOldestUnreadMentionOfMeForConversation: (
conversationId: string,
options: {
storyId?: string;
includeStoryReplies: boolean;
}
): MessageMetricsType | undefined;
) => MessageMetricsType | undefined;
getReactionByTimestamp: (
fromId: string,
@@ -980,37 +980,37 @@ type ReadableInterface = {
conversationId: string;
includeStoryReplies: boolean;
}) => ConversationMessageStatsType;
getLastConversationMessage(options: {
getLastConversationMessage: (options: {
conversationId: string;
}): MessageType | undefined;
}) => MessageType | undefined;
getAllCallHistory: () => ReadonlyArray<CallHistoryDetails>;
getCallHistoryUnreadCount(): number;
getCallHistoryMessageByCallId(options: {
getCallHistoryUnreadCount: () => number;
getCallHistoryMessageByCallId: (options: {
conversationId: string;
callId: string;
}): MessageType | undefined;
getCallHistory(
}) => MessageType | undefined;
getCallHistory: (
callId: string,
peerId: ServiceIdString | string
): CallHistoryDetails | undefined;
getCallHistoryGroupsCount(filter: CallHistoryFilter): number;
getCallHistoryGroups(
) => CallHistoryDetails | undefined;
getCallHistoryGroupsCount: (filter: CallHistoryFilter) => number;
getCallHistoryGroups: (
filter: CallHistoryFilter,
pagination: CallHistoryPagination
): Array<CallHistoryGroup>;
) => Array<CallHistoryGroup>;
hasGroupCallHistoryMessage: (
conversationId: string,
eraId: string
) => boolean;
callLinkExists(roomId: string): boolean;
defunctCallLinkExists(roomId: string): boolean;
callLinkExists: (roomId: string) => boolean;
defunctCallLinkExists: (roomId: string) => boolean;
getAllCallLinks: () => ReadonlyArray<CallLinkType>;
getCallLinkByRoomId: (roomId: string) => CallLinkType | undefined;
getCallLinkRecordByRoomId: (roomId: string) => CallLinkRecord | undefined;
getAllAdminCallLinks(): ReadonlyArray<CallLinkType>;
getAllCallLinkRecordsWithAdminKey(): ReadonlyArray<CallLinkRecord>;
getAllDefunctCallLinksWithAdminKey(): ReadonlyArray<DefunctCallLinkType>;
getAllMarkedDeletedCallLinkRoomIds(): ReadonlyArray<string>;
getAllAdminCallLinks: () => ReadonlyArray<CallLinkType>;
getAllCallLinkRecordsWithAdminKey: () => ReadonlyArray<CallLinkRecord>;
getAllDefunctCallLinksWithAdminKey: () => ReadonlyArray<DefunctCallLinkType>;
getAllMarkedDeletedCallLinkRoomIds: () => ReadonlyArray<string>;
getMessagesBetween: (
conversationId: string,
options: GetMessagesBetweenOptions
@@ -1031,12 +1031,12 @@ type ReadableInterface = {
getUnprocessedCount: () => number;
// Test-only
_getAttachmentDownloadJob(
_getAttachmentDownloadJob: (
job: Pick<
AttachmentDownloadJobType,
'messageId' | 'attachmentType' | 'attachmentSignature'
>
): AttachmentDownloadJobType | undefined;
) => AttachmentDownloadJobType | undefined;
getBackupCdnObjectMetadata: (
mediaId: string
@@ -1053,28 +1053,30 @@ type ReadableInterface = {
getRecentEmojis: (limit: number) => ReadonlyArray<Emoji.Parent>;
getRecentGifs: (limit: number) => ReadonlyArray<GifType>;
getAllBadges(): Array<BadgeType>;
getAllBadges: () => Array<BadgeType>;
_getAllStoryDistributions(): Array<StoryDistributionType>;
_getAllStoryDistributionMembers(): Array<StoryDistributionMemberType>;
getAllStoryDistributionsWithMembers(): Array<StoryDistributionWithMembersType>;
getStoryDistributionWithMembers(
_getAllStoryDistributions: () => Array<StoryDistributionType>;
_getAllStoryDistributionMembers: () => Array<StoryDistributionMemberType>;
getAllStoryDistributionsWithMembers: () => Array<StoryDistributionWithMembersType>;
getStoryDistributionWithMembers: (
id: string
): StoryDistributionWithMembersType | undefined;
) => StoryDistributionWithMembersType | undefined;
_getAllStoryReads(): Array<StoryReadType>;
getLastStoryReadsForAuthor(options: {
_getAllStoryReads: () => Array<StoryReadType>;
getLastStoryReadsForAuthor: (options: {
authorId: ServiceIdString;
conversationId?: string;
limit?: number;
}): Array<StoryReadType>;
countStoryReadsByConversation(conversationId: string): number;
}) => Array<StoryReadType>;
countStoryReadsByConversation: (conversationId: string) => number;
getAllNotificationProfiles(): Array<NotificationProfileType>;
getNotificationProfileById(id: string): NotificationProfileType | undefined;
getAllNotificationProfiles: () => Array<NotificationProfileType>;
getNotificationProfileById: (
id: string
) => NotificationProfileType | undefined;
getAllDonationReceipts(): Array<DonationReceipt>;
getDonationReceiptById(id: string): DonationReceipt | undefined;
getAllDonationReceipts: () => Array<DonationReceipt>;
getDonationReceiptById: (id: string) => DonationReceipt | undefined;
getAllChatFolders: () => ReadonlyArray<ChatFolder>;
getCurrentChatFolders: () => ReadonlyArray<CurrentChatFolder>;
@@ -1104,14 +1106,14 @@ type ReadableInterface = {
sourceServiceId?: string
) => Array<string>;
getJobsInQueue(queueType: string): Array<StoredJob>;
getJobsInQueue: (queueType: string) => Array<StoredJob>;
wasGroupCallRingPreviouslyCanceled(ringId: bigint): boolean;
wasGroupCallRingPreviouslyCanceled: (ringId: bigint) => boolean;
getMaxMessageCounter(): number | undefined;
getMaxMessageCounter: () => number | undefined;
getStatisticsForLogging(): Record<string, string>;
getBackupAttachmentDownloadProgress(): BackupAttachmentDownloadProgress;
getStatisticsForLogging: () => Record<string, string>;
getBackupAttachmentDownloadProgress: () => BackupAttachmentDownloadProgress;
getAttachmentReferencesForMessages: (
messageIds: Array<string>
) => Array<MessageAttachmentDBType>;
@@ -1189,14 +1191,14 @@ type WritableInterface = {
createOrUpdateSession: (data: SessionType) => void;
createOrUpdateSessions: (array: Array<SessionType>) => void;
commitDecryptResult(options: {
commitDecryptResult: (options: {
kyberPreKeysToRemove: Array<PreKeyIdType>;
preKeysToRemove: Array<PreKeyIdType>;
senderKeys: Array<SenderKeyType>;
sessions: Array<SessionType>;
unprocessed: Array<UnprocessedType>;
kyberTriples: Array<KyberPreKeyTripleType>;
}): void;
}) => void;
removeSessionById: (id: SessionIdType) => number;
removeSessionsByConversation: (conversationId: string) => void;
removeSessionsByServiceId: (serviceId: ServiceIdString) => void;
@@ -1272,30 +1274,30 @@ type WritableInterface = {
_removeAllCallHistory: () => void;
markCallHistoryDeleted: (callId: string) => void;
cleanupCallHistoryMessages: () => void;
markCallHistoryRead(callId: string): void;
markAllCallHistoryRead(target: CallLogEventTarget): number;
markAllCallHistoryReadInConversation(target: CallLogEventTarget): number;
saveCallHistory(callHistory: CallHistoryDetails): void;
markCallHistoryMissed(callIds: ReadonlyArray<string>): void;
getRecentStaleRingsAndMarkOlderMissed(): ReadonlyArray<MaybeStaleCallHistory>;
insertCallLink(callLink: CallLinkType): void;
insertOrUpdateCallLinkFromSync(
markCallHistoryRead: (callId: string) => void;
markAllCallHistoryRead: (target: CallLogEventTarget) => number;
markAllCallHistoryReadInConversation: (target: CallLogEventTarget) => number;
saveCallHistory: (callHistory: CallHistoryDetails) => void;
markCallHistoryMissed: (callIds: ReadonlyArray<string>) => void;
getRecentStaleRingsAndMarkOlderMissed: () => ReadonlyArray<MaybeStaleCallHistory>;
insertCallLink: (callLink: CallLinkType) => void;
insertOrUpdateCallLinkFromSync: (
callLink: CallLinkType
): InsertOrUpdateCallLinkFromSyncResult;
updateCallLink(callLink: CallLinkType): void;
updateCallLinkState(
) => InsertOrUpdateCallLinkFromSyncResult;
updateCallLink: (callLink: CallLinkType) => void;
updateCallLinkState: (
roomId: string,
callLinkState: CallLinkStateType
): CallLinkType;
beginDeleteAllCallLinks(): boolean;
beginDeleteCallLink(roomId: string): boolean;
deleteCallHistoryByRoomId(roomid: string): void;
deleteCallLinkAndHistory(roomId: string): void;
finalizeDeleteCallLink(roomId: string): void;
_removeAllCallLinks(): void;
insertDefunctCallLink(defunctCallLink: DefunctCallLinkType): void;
updateDefunctCallLink(defunctCallLink: DefunctCallLinkType): void;
deleteCallLinkFromSync(roomId: string): void;
) => CallLinkType;
beginDeleteAllCallLinks: () => boolean;
beginDeleteCallLink: (roomId: string) => boolean;
deleteCallHistoryByRoomId: (roomid: string) => void;
deleteCallLinkAndHistory: (roomId: string) => void;
finalizeDeleteCallLink: (roomId: string) => void;
_removeAllCallLinks: () => void;
insertDefunctCallLink: (defunctCallLink: DefunctCallLinkType) => void;
updateDefunctCallLink: (defunctCallLink: DefunctCallLinkType) => void;
deleteCallLinkFromSync: (roomId: string) => void;
migrateConversationMessages: (obsoleteId: string, currentId: string) => void;
saveEditedMessage: (
mainMessage: ReadonlyDeep<MessageType>,
@@ -1399,42 +1401,42 @@ type WritableInterface = {
addRecentGif: (gif: GifType, lastUsedAt: number, maxRecents: number) => void;
removeRecentGif: (gif: GifType['id']) => void;
updateOrCreateBadges(badges: ReadonlyArray<BadgeType>): void;
badgeImageFileDownloaded(url: string, localPath: string): void;
updateOrCreateBadges: (badges: ReadonlyArray<BadgeType>) => void;
badgeImageFileDownloaded: (url: string, localPath: string) => void;
_deleteAllStoryDistributions(): void;
createNewStoryDistribution(
_deleteAllStoryDistributions: () => void;
createNewStoryDistribution: (
distribution: StoryDistributionWithMembersType
): void;
modifyStoryDistribution(distribution: StoryDistributionType): void;
modifyStoryDistributionMembers(
) => void;
modifyStoryDistribution: (distribution: StoryDistributionType) => void;
modifyStoryDistributionMembers: (
listId: string,
options: {
toAdd: Array<ServiceIdString>;
toRemove: Array<ServiceIdString>;
}
): void;
modifyStoryDistributionWithMembers(
) => void;
modifyStoryDistributionWithMembers: (
distribution: StoryDistributionType,
options: {
toAdd: Array<ServiceIdString>;
toRemove: Array<ServiceIdString>;
}
): void;
deleteStoryDistribution(id: StoryDistributionIdString): void;
) => void;
deleteStoryDistribution: (id: StoryDistributionIdString) => void;
_deleteAllStoryReads(): void;
addNewStoryRead(read: StoryReadType): void;
_deleteAllStoryReads: () => void;
addNewStoryRead: (read: StoryReadType) => void;
_deleteAllNotificationProfiles(): void;
deleteNotificationProfileById(id: string): void;
markNotificationProfileDeleted(id: string): number | undefined;
createNotificationProfile(profile: NotificationProfileType): void;
updateNotificationProfile(profile: NotificationProfileType): void;
_deleteAllNotificationProfiles: () => void;
deleteNotificationProfileById: (id: string) => void;
markNotificationProfileDeleted: (id: string) => number | undefined;
createNotificationProfile: (profile: NotificationProfileType) => void;
updateNotificationProfile: (profile: NotificationProfileType) => void;
_deleteAllDonationReceipts(): void;
deleteDonationReceiptById(id: string): void;
createDonationReceipt(profile: DonationReceipt): void;
_deleteAllDonationReceipts: () => void;
deleteDonationReceiptById: (id: string) => void;
createDonationReceipt: (profile: DonationReceipt) => void;
createChatFolder: (chatFolder: ChatFolder) => void;
createAllChatsChatFolder: () => ChatFolder;
@@ -1502,20 +1504,20 @@ type WritableInterface = {
removeAllConfiguration: (isPrimary: boolean) => void;
eraseStorageServiceState: () => void;
insertJob(job: Readonly<StoredJob>): void;
deleteJob(id: string): void;
insertJob: (job: Readonly<StoredJob>) => void;
deleteJob: (id: string) => void;
disableMessageInsertTriggers(): void;
enableMessageInsertTriggersAndBackfill(): void;
ensureMessageInsertTriggersAreEnabled(): void;
disableMessageInsertTriggers: () => void;
enableMessageInsertTriggersAndBackfill: () => void;
ensureMessageInsertTriggersAreEnabled: () => void;
disableFSync(): void;
enableFSyncAndCheckpoint(): void;
disableFSync: () => void;
enableFSyncAndCheckpoint: () => void;
processGroupCallRingCancellation(ringId: bigint): void;
cleanExpiredGroupCallRingCancellations(): void;
processGroupCallRingCancellation: (ringId: bigint) => void;
cleanExpiredGroupCallRingCancellations: () => void;
_testOnlyRemoveMessageAttachments(timestamp: number): void;
_testOnlyRemoveMessageAttachments: (timestamp: number) => void;
};
// Adds a database argument
@@ -1539,10 +1541,10 @@ export type ServerReadableDirectInterface = ReadableInterface & {
contactServiceIdsMatchingQuery?: Array<ServiceIdString>;
}) => Array<ServerSearchResultMessageType>;
getRecentStoryReplies(
getRecentStoryReplies: (
storyId: string,
options?: GetRecentStoryRepliesOptionsType
): Array<MessageType>;
) => Array<MessageType>;
getOlderMessagesByConversation: (
options: AdjacentMessagesByConversationOptionsType
) => Array<MessageType>;
@@ -1569,7 +1571,7 @@ export type ServerReadableDirectInterface = ReadableInterface & {
) => StoredSignedPreKeyType | undefined;
getAllSignedPreKeys: () => Array<StoredSignedPreKeyType>;
getItemById<K extends ItemKeyType>(id: K): StoredItemType<K> | undefined;
getItemById: <K extends ItemKeyType>(id: K) => StoredItemType<K> | undefined;
getAllItems: () => StoredAllItemsType;
// Server-only
@@ -1636,7 +1638,7 @@ export type ServerWritableDirectInterface = WritableInterface & {
createOrUpdateSignedPreKey: (data: StoredSignedPreKeyType) => void;
bulkAddSignedPreKeys: (array: Array<StoredSignedPreKeyType>) => void;
createOrUpdateItem<K extends ItemKeyType>(data: StoredItemType<K>): void;
createOrUpdateItem: <K extends ItemKeyType>(data: StoredItemType<K>) => void;
// Server-only
@@ -1672,10 +1674,10 @@ export type ClientOnlyReadableInterface = ClientInterfaceWrap<{
contactServiceIdsMatchingQuery?: Array<ServiceIdString>;
}) => Array<ClientSearchResultMessageType>;
getRecentStoryReplies(
getRecentStoryReplies: (
storyId: string,
options?: GetRecentStoryRepliesOptionsType
): Array<MessageType>;
) => Array<MessageType>;
getOlderMessagesByConversation: (
options: AdjacentMessagesByConversationOptionsType
) => Array<MessageType>;
@@ -1698,7 +1700,7 @@ export type ClientOnlyReadableInterface = ClientInterfaceWrap<{
getSignedPreKeyById: (id: SignedPreKeyIdType) => SignedPreKeyType | undefined;
getAllSignedPreKeys: () => Array<SignedPreKeyType>;
getItemById<K extends ItemKeyType>(id: K): ItemType<K> | undefined;
getItemById: <K extends ItemKeyType>(id: K) => ItemType<K> | undefined;
getAllItems: () => AllItemsType;
}>;
@@ -1752,7 +1754,7 @@ export type ClientOnlyWritableInterface = ClientInterfaceWrap<{
createOrUpdateSignedPreKey: (data: SignedPreKeyType) => void;
bulkAddSignedPreKeys: (array: Array<SignedPreKeyType>) => void;
createOrUpdateItem<K extends ItemKeyType>(data: ItemType<K>): void;
createOrUpdateItem: <K extends ItemKeyType>(data: ItemType<K>) => void;
// Client-side only