Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 12:19:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make our binary comparisons constant time (#2047)

Browse Source
This commit is contained in:
Scott Nonnenberg
2018-02-14 12:15:26 -08:00
committed by GitHub
parent 4033a9f813
commit 2cfdaca3c1
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/models/conversations.js
View File

@@ -32,13 +32,13 @@
if (ab1.byteLength !== ab2.byteLength) {
return false;
}
var result = true;
var result = 0;
var ta1 = new Uint8Array(ab1);
var ta2 = new Uint8Array(ab2);
for (var i = 0; i < ab1.byteLength; ++i) {
if (ta1[i] !== ta2[i]) { result = false; }
result = result | ta1[i] ^ ta2[i];
}
return result;
return result === 0;
}
Whisper.Conversation = Backbone.Model.extend({