From 319890d138b9ffae980c9456e85adb7bf8e0c708 Mon Sep 17 00:00:00 2001
From: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
Date: Mon, 9 Sep 2024 14:00:21 -0700
Subject: [PATCH] Better exception handling for getDomain

---
 ts/components/StoryLinkPreview.tsx | 6 +++---
 ts/components/TextAttachment.tsx   | 4 ++--
 ts/state/selectors/linkPreviews.ts | 4 ++--
 ts/state/selectors/message.ts      | 8 ++++++--
 ts/types/LinkPreview.ts            | 8 ++++++++
 5 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/ts/components/StoryLinkPreview.tsx b/ts/components/StoryLinkPreview.tsx
index 35a6184640..6a4a7b1f05 100644
--- a/ts/components/StoryLinkPreview.tsx
+++ b/ts/components/StoryLinkPreview.tsx
@@ -9,7 +9,7 @@ import type { LinkPreviewType } from '../types/message/LinkPreviews';
 import type { LocalizerType } from '../types/Util';
 import { CurveType, Image } from './conversation/Image';
 import { isImageAttachment } from '../types/Attachment';
-import { getDomain } from '../types/LinkPreview';
+import { getSafeDomain } from '../types/LinkPreview';
 
 export type Props = LinkPreviewType & {
   forceCompactMode?: boolean;
@@ -26,7 +26,7 @@ export function StoryLinkPreview({
   url,
 }: Props): JSX.Element {
   const isImage = isImageAttachment(image);
-  const location = domain || getDomain(String(url));
+  const location = domain || getSafeDomain(String(url));
   const isCompact = forceCompactMode || !image;
 
   let content: JSX.Element | undefined;
@@ -74,7 +74,7 @@ export function StoryLinkPreview({
         <div className="StoryLinkPreview__icon-container">
           <Image
             alt={i18n('icu:stagedPreviewThumbnail', {
-              domain: location,
+              domain: location || '',
             })}
             attachment={image}
             curveBottomLeft={CurveType.Tiny}
diff --git a/ts/components/TextAttachment.tsx b/ts/components/TextAttachment.tsx
index a052edf1ed..286b9581fe 100644
--- a/ts/components/TextAttachment.tsx
+++ b/ts/components/TextAttachment.tsx
@@ -12,7 +12,7 @@ import { Emojify } from './conversation/Emojify';
 import { StoryLinkPreview } from './StoryLinkPreview';
 import { TextAttachmentStyleType } from '../types/Attachment';
 import { count } from '../util/grapheme';
-import { getDomain } from '../types/LinkPreview';
+import { getSafeDomain } from '../types/LinkPreview';
 import { getFontNameByTextScript } from '../util/getFontNameByTextScript';
 import {
   COLOR_WHITE_INT,
@@ -295,7 +295,7 @@ export const TextAttachment = forwardRef<HTMLTextAreaElement, PropsType>(
               )}
               <StoryLinkPreview
                 {...textAttachment.preview}
-                domain={getDomain(String(textAttachment.preview.url))}
+                domain={getSafeDomain(String(textAttachment.preview.url))}
                 forceCompactMode={getTextSize(textContent) !== TextSize.Large}
                 i18n={i18n}
                 title={textAttachment.preview.title || undefined}
diff --git a/ts/state/selectors/linkPreviews.ts b/ts/state/selectors/linkPreviews.ts
index e2ba7f7afd..f1668d440f 100644
--- a/ts/state/selectors/linkPreviews.ts
+++ b/ts/state/selectors/linkPreviews.ts
@@ -4,7 +4,7 @@
 import { createSelector } from 'reselect';
 
 import { assertDev } from '../../util/assert';
-import { getDomain } from '../../types/LinkPreview';
+import { getSafeDomain } from '../../types/LinkPreview';
 
 import type { LinkPreviewSourceType } from '../../types/LinkPreview';
 import type { StateType } from '../reducer';
@@ -21,7 +21,7 @@ export const getLinkPreview = createSelector(
         return;
       }
 
-      const domain = getDomain(linkPreview.url);
+      const domain = getSafeDomain(linkPreview.url);
       assertDev(
         domain !== undefined,
         "Domain of linkPreview can't be undefined"
diff --git a/ts/state/selectors/message.ts b/ts/state/selectors/message.ts
index a375c95882..b264c96907 100644
--- a/ts/state/selectors/message.ts
+++ b/ts/state/selectors/message.ts
@@ -43,7 +43,11 @@ import type {
 } from '../../components/conversation/GroupNotification';
 import type { PropsType as ProfileChangeNotificationPropsType } from '../../components/conversation/ProfileChangeNotification';
 
-import { getDomain, isCallLink, isStickerPack } from '../../types/LinkPreview';
+import {
+  getSafeDomain,
+  isCallLink,
+  isStickerPack,
+} from '../../types/LinkPreview';
 import type {
   AciString,
   PniString,
@@ -390,7 +394,7 @@ const getPreviewsForMessage = ({
     ...preview,
     isStickerPack: isStickerPack(preview.url),
     isCallLink: isCallLink(preview.url),
-    domain: getDomain(preview.url),
+    domain: getSafeDomain(preview.url),
     image: preview.image ? getPropsForAttachment(preview.image) : undefined,
   }));
 };
diff --git a/ts/types/LinkPreview.ts b/ts/types/LinkPreview.ts
index ab8626b61a..d8c93d9be6 100644
--- a/ts/types/LinkPreview.ts
+++ b/ts/types/LinkPreview.ts
@@ -146,6 +146,14 @@ export function findLinks(text: string, caretLocation?: number): Array<string> {
   );
 }
 
+export function getSafeDomain(href: string): string | undefined {
+  try {
+    return getDomain(href);
+  } catch {
+    return undefined;
+  }
+}
+
 export function getDomain(href: string): string {
   const url = maybeParseUrl(href);
   if (!url || !url.hostname) {