Auto-fixes: UX Improvements (#2077)

* Whitelist `conversation_search_view` for ESLint

* Autofix `conversation_search_view`

* Remove Vim modeline

* Whitelist globals for ESLint

* Ignore unnamed module IIFE

* Whitelist legacy `then` expressions

* Extract `isSearchable`

Fixes line length violations.

* Remove unused constant

* Remove unnecessary escaping for parens

Suggested by ESLint `no-useless-escape` rule.

* 🎨 Organize file list

* Whitelist `inbox_view` for ESLint

* Autofix `inbox_view`

* Remove Vim modeline

* Add function names

* Whitelist globals for ESLint

* Fix lint errors

* 🔤 `options` properties

* 🎨 Improve `then` chain formatting

* Consider `js/*.js` files as scripts not modules

Forces use of 'use strict' directive per ESLint.

* Ignore unnamed module IIFE

* Fix function argument line breaks

app/menu.js

@@ -1,14 +1,14 @@
 function createTemplate(options, messages) {
   const {
-    showDebugLog,
-    showAbout,
-    openReleaseNotes,
-    openNewBugForm,
-    openSupportPage,
     openForums,
-    setupWithImport,
+    openNewBugForm,
+    openReleaseNotes,
+    openSupportPage,
     setupAsNewDevice,
     setupAsStandalone,
+    setupWithImport,
+    showAbout,
+    showDebugLog,
   } = options;
 
   const template = [{
@@ -156,11 +156,11 @@ function createTemplate(options, messages) {
 
 function updateForMac(template, messages, options) {
   const {
-    showWindow,
-    showAbout,
-    setupWithImport,
     setupAsNewDevice,
     setupAsStandalone,
+    setupWithImport,
+    showAbout,
+    showWindow,
   } = options;
 
   // Remove About item and separator from Help menu, since it's on the first menu