From 40b4b32db4762067147c799d75ed69f5345ec0e2 Mon Sep 17 00:00:00 2001 From: automated-signal <37887102+automated-signal@users.noreply.github.com> Date: Fri, 6 Mar 2026 18:39:05 -0600 Subject: [PATCH] Update icon for member label permission timeline update Co-authored-by: Scott Nonnenberg --- .../conversation/GroupV2Change.dom.tsx | 61 ++++++++++--------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/ts/components/conversation/GroupV2Change.dom.tsx b/ts/components/conversation/GroupV2Change.dom.tsx index 4debe1aa71..6ddb68e5dc 100644 --- a/ts/components/conversation/GroupV2Change.dom.tsx +++ b/ts/components/conversation/GroupV2Change.dom.tsx @@ -91,39 +91,42 @@ type GroupIconType = | 'group-leave' | 'group-remove'; -const changeToIconMap = new Map([ - ['access-attributes', 'group-access'], - ['access-invite-link', 'group-access'], - ['access-members', 'group-access'], - ['admin-approval-add-one', 'group-add'], - ['admin-approval-remove-one', 'group-decline'], - ['admin-approval-bounce', 'group-decline'], - ['announcements-only', 'group-access'], - ['avatar', 'group-avatar'], - ['description', 'group-edit'], - ['group-link-add', 'group-access'], - ['group-link-remove', 'group-access'], - ['group-link-reset', 'group-access'], - ['member-add', 'group-add'], - ['member-add-from-admin-approval', 'group-approved'], - ['member-add-from-invite', 'group-add'], - ['member-add-from-link', 'group-add'], - ['member-privilege', 'group-access'], - ['member-remove', 'group-remove'], - ['pending-add-many', 'group-add'], - ['pending-add-one', 'group-add'], - ['pending-remove-many', 'group-decline'], - ['pending-remove-one', 'group-decline'], - ['title', 'group-edit'], -]); - +const changeToIconMap: Record = + { + 'access-attributes': 'group-access', + 'access-invite-link': 'group-access', + 'access-member-label': 'group-access', + 'access-members': 'group-access', + 'admin-approval-add-one': 'group-add', + 'admin-approval-bounce': 'group-decline', + 'admin-approval-remove-one': 'group-decline', + 'announcements-only': 'group-access', + avatar: 'group-avatar', + create: 'group', + description: 'group-edit', + 'group-link-add': 'group-access', + 'group-link-remove': 'group-access', + 'group-link-reset': 'group-access', + 'member-add': 'group-add', + 'member-add-from-admin-approval': 'group-approved', + 'member-add-from-invite': 'group-add', + 'member-add-from-link': 'group-add', + 'member-privilege': 'group-access', + 'member-remove': 'group-remove', + 'pending-add-many': 'group-add', + 'pending-add-one': 'group-add', + 'pending-remove-many': 'group-decline', + 'pending-remove-one': 'group-decline', + summary: 'group-summary', + title: 'group-edit', + }; function getIcon( detail: GroupV2ChangeDetailType, isLastText = true, fromId?: ServiceIdString ): GroupIconType { const changeType = detail.type; - let possibleIcon = changeToIconMap.get(changeType); + let possibleIcon: GroupIconType | undefined = changeToIconMap[changeType]; const isSameId = fromId === get(detail, 'aci', null); if (isSameId) { if (changeType === 'member-remove') { @@ -138,9 +141,7 @@ function getIcon( if (changeType === 'admin-approval-bounce' && isLastText) { possibleIcon = undefined; } - if (changeType === 'summary') { - possibleIcon = 'group-summary'; - } + return possibleIcon || 'group'; }