Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-24 18:38:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve handling of group story replies

Browse Source
This commit is contained in:
trevor-signal
2025-12-04 17:06:25 -05:00
committed by GitHub
parent efe2c8de71
commit 465cf7af41
5 changed files with 165 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

108
ts/test-node/sql/migration_1580_test.node.ts Normal file
View File

@@ -0,0 +1,108 @@
// Copyright 2025 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
import { assert } from 'chai';
import { type WritableDB } from '../../sql/Interface.std.js';
import {
createDB,
getTableData,
insertData,
updateToVersion,
} from './helpers.node.js';
describe('SQL/updateToSchemaVersion1580', () => {
let db: WritableDB;
beforeEach(() => {
db = createDB();
updateToVersion(db, 1570);
});
afterEach(() => {
db.close();
});
it('deletes any expired group story replies', () => {
insertData(db, 'conversations', [
{
id: 'groupConvoId',
type: 'group',
},
{
id: 'directConvoId',
type: 'private',
},
]);
insertData(db, 'messages', [
{
id: 'story-that-exists',
type: 'story',
conversationId: 'groupConvoId',
timestamp: Date.now(),
},
{
id: 'doe-story',
type: 'story',
conversationId: 'groupConvoId',
timestamp: Date.now(),
isErased: 1,
},
{
id: 'group-reply-to-existing-story',
conversationId: 'groupConvoId',
timestamp: Date.now(),
storyId: 'story-that-exists',
},
{
id: 'group-reply-to-non-existing-story',
conversationId: 'groupConvoId',
timestamp: Date.now(),
storyId: 'story-that-does-not-exist',
},
{
id: 'group-reply-to-doe-story',
conversationId: 'groupConvoId',
timestamp: Date.now(),
storyId: 'doe-story',
},
{
id: 'direct-reply-to-existing-story',
conversationId: 'directConvoId',
timestamp: Date.now(),
storyId: 'storyThatExists',
},
{
id: 'direct-reply-to-non-existing-story',
conversationId: 'directConvoId',
timestamp: Date.now(),
storyId: 'storyThatDoesNotExist',
},
{
id: 'normal-group-message',
conversationId: 'groupConvoId',
timestamp: Date.now(),
},
{
id: 'normal-direct-message',
conversationId: 'directConvoId',
timestamp: Date.now(),
},
]);
updateToVersion(db, 1580);
assert.deepStrictEqual(
getTableData(db, 'messages').map(row => row.id),
[
'story-that-exists',
'doe-story',
'group-reply-to-existing-story',
// 'group-reply-to-non-existing-story', <-- DELETED!
// 'group-reply-to-doe-story', <-- DELETED!
'direct-reply-to-existing-story',
'direct-reply-to-non-existing-story',
'normal-group-message',
'normal-direct-message',
]
);
});
});