Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-24 18:38:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make verified notifications consistent

Browse Source
This commit is contained in:
Scott Nonnenberg
2025-10-10 04:09:12 +10:00
committed by GitHub
parent 75269adfe1
commit 4e2827af4b
3 changed files with 45 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
ts/test-electron/SignalProtocolStore_test.ts
View File

@@ -710,12 +710,13 @@ describe('SignalProtocolStore', () => {
it('should create an identity and set verified to DEFAULT', async () => {
const newAci = generateAci();
const needsNotification = await store.updateIdentityAfterSync(
newAci,
store.VerifiedStatus.DEFAULT,
newIdentity
);
assert.isFalse(needsNotification);
const { shouldAddVerifiedChangedMessage } =
await store.updateIdentityAfterSync(
newAci,
store.VerifiedStatus.DEFAULT,
newIdentity
);
assert.isFalse(shouldAddVerifiedChangedMessage);
assert.strictEqual(keychangeTriggered, 0);
const identity = await DataReader.getIdentityKeyById(newAci);
@@ -729,12 +730,13 @@ describe('SignalProtocolStore', () => {
it('should create an identity and set verified to VERIFIED', async () => {
const newAci = generateAci();
const needsNotification = await store.updateIdentityAfterSync(
newAci,
store.VerifiedStatus.VERIFIED,
newIdentity
);
assert.isTrue(needsNotification);
const { shouldAddVerifiedChangedMessage } =
await store.updateIdentityAfterSync(
newAci,
store.VerifiedStatus.VERIFIED,
newIdentity
);
assert.isTrue(shouldAddVerifiedChangedMessage);
assert.strictEqual(keychangeTriggered, 0);
const identity = await DataReader.getIdentityKeyById(newAci);
@@ -746,12 +748,13 @@ describe('SignalProtocolStore', () => {
});
it('should update public key without verified change', async () => {
const needsNotification = await store.updateIdentityAfterSync(
theirAci,
store.VerifiedStatus.DEFAULT,
newIdentity
);
assert.isFalse(needsNotification);
const { shouldAddVerifiedChangedMessage } =
await store.updateIdentityAfterSync(
theirAci,
store.VerifiedStatus.DEFAULT,
newIdentity
);
assert.isFalse(shouldAddVerifiedChangedMessage);
assert.strictEqual(keychangeTriggered, 1);
const identity = await DataReader.getIdentityKeyById(theirAci);
@@ -763,12 +766,13 @@ describe('SignalProtocolStore', () => {
});
it('should update verified without public key change', async () => {
const needsNotification = await store.updateIdentityAfterSync(
theirAci,
store.VerifiedStatus.VERIFIED,
testKey.publicKey.serialize()
);
assert.isTrue(needsNotification);
const { shouldAddVerifiedChangedMessage } =
await store.updateIdentityAfterSync(
theirAci,
store.VerifiedStatus.VERIFIED,
testKey.publicKey.serialize()
);
assert.isTrue(shouldAddVerifiedChangedMessage);
assert.strictEqual(keychangeTriggered, 0);
const identity = await DataReader.getIdentityKeyById(theirAci);