Uint8Array migration

libtextsecure/test/.eslintrc.js

@@ -16,9 +16,6 @@ module.exports = {
   },
   globals: {
     assert: true,
-    assertEqualArrayBuffers: true,
     getString: true,
-    hexToArrayBuffer: true,
-    stringToArrayBuffer: true,
   },
 };

libtextsecure/test/_test.js

@@ -46,18 +46,6 @@ mocha.reporter(SauceReporter);
 /*
  * global helpers for tests
  */
-window.assertEqualArrayBuffers = (ab1, ab2) => {
-  assert.deepEqual(new Uint8Array(ab1), new Uint8Array(ab2));
-};
-
-window.hexToArrayBuffer = str => {
-  const ret = new ArrayBuffer(str.length / 2);
-  const array = new Uint8Array(ret);
-  for (let i = 0; i < str.length / 2; i += 1) {
-    array[i] = parseInt(str.substr(i * 2, 2), 16);
-  }
-  return ret;
-};
 
 window.Whisper = window.Whisper || {};
 window.Whisper.events = {

libtextsecure/test/helpers_test.js

@@ -1,35 +0,0 @@
-// Copyright 2015-2020 Signal Messenger, LLC
-// SPDX-License-Identifier: AGPL-3.0-only
-
-describe('Helpers', () => {
-  describe('ArrayBuffer->String conversion', () => {
-    it('works', () => {
-      const b = new ArrayBuffer(3);
-      const a = new Uint8Array(b);
-      a[0] = 0;
-      a[1] = 255;
-      a[2] = 128;
-      assert.equal(window.textsecure.utils.getString(b), '\x00\xff\x80');
-    });
-  });
-
-  describe('stringToArrayBuffer', () => {
-    it('returns ArrayBuffer when passed string', () => {
-      const anArrayBuffer = new ArrayBuffer(1);
-      const typedArray = new Uint8Array(anArrayBuffer);
-      typedArray[0] = 'a'.charCodeAt(0);
-      assertEqualArrayBuffers(
-        window.textsecure.utils.stringToArrayBuffer('a'),
-        anArrayBuffer
-      );
-    });
-    it('throws an error when passed a non string', () => {
-      const notStringable = [{}, undefined, null, new ArrayBuffer()];
-      notStringable.forEach(notString => {
-        assert.throw(() => {
-          window.textsecure.utils.stringToArrayBuffer(notString);
-        }, Error);
-      });
-    });
-  });
-});

libtextsecure/test/index.html

@@ -31,7 +31,6 @@
       data-cover
     ></script>
 
-    <script type="text/javascript" src="helpers_test.js"></script>
     <script type="text/javascript" src="task_with_timeout_test.js"></script>
     <script type="text/javascript" src="account_manager_test.js"></script>
     <script type="text/javascript" src="sendmessage_test.js"></script>