From 4f249f690c65f52e74ff09ecfd2d8ed5cecaef1c Mon Sep 17 00:00:00 2001
From: automated-signal <37887102+automated-signal@users.noreply.github.com>
Date: Tue, 6 Feb 2024 13:41:44 -0600
Subject: [PATCH] Add extra PNP string to settings

Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
---
 _locales/en/messages.json     |  8 ++++++--
 ts/components/Preferences.tsx | 21 ++++++++++++++++-----
 2 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index fcfd959cfb..6b0d8c9e1f 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -5844,8 +5844,12 @@
     "description": "Description for the phone number sharing setting row when the value is Everyone"
   },
   "icu:Preferences__pnp__sharing--description--nobody": {
-    "messageformat": "Nobody will see your phone number on Signal, even when you're messaging them.",
-    "description": "Description for the phone number sharing setting row when the value is Nobody"
+    "messageformat": "Your phone number will not be visible to anyone unless they have it saved in their phone’s contacts.",
+    "description": "Description for the phone number sharing setting row when the value is Nobody and phone number discoverability setting is Everyone"
+  },
+  "icu:Preferences__pnp__sharing--description--nobody--not-discoverable": {
+    "messageformat": "Your phone number will not be visible to anyone.",
+    "description": "Description for the phone number sharing setting row when the value is Nobody and phone number discoverability setting is Nobody"
   },
   "icu:Preferences__pnp--page-title": {
     "messageformat": "Phone Number",
diff --git a/ts/components/Preferences.tsx b/ts/components/Preferences.tsx
index 63d0bba46e..09cb726334 100644
--- a/ts/components/Preferences.tsx
+++ b/ts/components/Preferences.tsx
@@ -1422,6 +1422,21 @@ export function Preferences({
       </>
     );
   } else if (page === Page.PNP) {
+    let sharingDescription: string;
+
+    if (whoCanSeeMe === PhoneNumberSharingMode.Everybody) {
+      sharingDescription = i18n(
+        'icu:Preferences__pnp__sharing--description--everyone'
+      );
+    } else if (whoCanFindMe === PhoneNumberDiscoverability.Discoverable) {
+      sharingDescription = i18n(
+        'icu:Preferences__pnp__sharing--description--nobody'
+      );
+    } else {
+      sharingDescription = i18n(
+        'icu:Preferences__pnp__sharing--description--nobody--not-discoverable'
+      );
+    }
     settings = (
       <>
         <div className="Preferences__title">
@@ -1458,11 +1473,7 @@ export function Preferences({
             value={whoCanSeeMe}
           />
           <div className="Preferences__padding">
-            <div className="Preferences__description">
-              {whoCanSeeMe === PhoneNumberSharingMode.Everybody
-                ? i18n('icu:Preferences__pnp__sharing--description--everyone')
-                : i18n('icu:Preferences__pnp__sharing--description--nobody')}
-            </div>
+            <div className="Preferences__description">{sharingDescription}</div>
           </div>
         </SettingsRow>