Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-05-08 08:58:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update quote behavior in backups

Browse Source
This commit is contained in:
trevor-signal
2024-11-12 17:00:46 -05:00
committed by GitHub
parent 104995e980
commit 541ba6c9de
12 changed files with 142 additions and 280 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ts/test-electron/backup/bubble_test.ts
+95 -29
View File
@@ -229,9 +229,80 @@ describe('backup/bubble messages', () => {
]);
});
it('roundtrips gift badge quote', async () => {
await symmetricRoundtripHarness([
{
describe('quotes', () => {
it('roundtrips gift badge quote', async () => {
await symmetricRoundtripHarness([
{
conversationId: contactA.id,
id: generateGuid(),
type: 'incoming',
received_at: 3,
received_at_ms: 3,
sent_at: 3,
sourceServiceId: CONTACT_A,
readStatus: ReadStatus.Unread,
seenStatus: SeenStatus.Unseen,
unidentifiedDeliveryReceived: true,
timestamp: 3,
giftBadge: {
id: undefined,
level: 100,
expiration: 1723248000000,
receiptCredentialPresentation: BADGE_RECEIPT,
state: GiftBadgeStates.Opened,
},
},
{
conversationId: contactA.id,
id: generateGuid(),
type: 'incoming',
received_at: 4,
received_at_ms: 4,
sent_at: 4,
sourceServiceId: CONTACT_A,
readStatus: ReadStatus.Unread,
seenStatus: SeenStatus.Unseen,
unidentifiedDeliveryReceived: true,
timestamp: 4,
quote: {
authorAci: CONTACT_A,
attachments: [],
id: 3,
isViewOnce: false,
isGiftBadge: true,
referencedMessageNotFound: false,
},
},
]);
});
it('roundtrips quote with referenced message found', async () => {
await symmetricRoundtripHarness([
{
conversationId: contactA.id,
id: generateGuid(),
type: 'incoming',
received_at: 3,
received_at_ms: 3,
sent_at: 3,
sourceServiceId: CONTACT_A,
readStatus: ReadStatus.Unread,
seenStatus: SeenStatus.Unseen,
unidentifiedDeliveryReceived: true,
timestamp: 3,
quote: {
authorAci: CONTACT_A,
attachments: [],
id: 42,
isGiftBadge: false,
text: 'quote text',
isViewOnce: false,
referencedMessageNotFound: false,
},
},
]);
});
it('roundtrips quote without referenced message found', async () => {
const message = {
conversationId: contactA.id,
id: generateGuid(),
type: 'incoming',
@@ -243,37 +314,32 @@ describe('backup/bubble messages', () => {
seenStatus: SeenStatus.Unseen,
unidentifiedDeliveryReceived: true,
timestamp: 3,
giftBadge: {
id: undefined,
level: 100,
expiration: 1723248000000,
receiptCredentialPresentation: BADGE_RECEIPT,
state: GiftBadgeStates.Opened,
},
},
{
conversationId: contactA.id,
id: generateGuid(),
type: 'incoming',
received_at: 4,
received_at_ms: 4,
sent_at: 4,
sourceServiceId: CONTACT_A,
readStatus: ReadStatus.Unread,
seenStatus: SeenStatus.Unseen,
unidentifiedDeliveryReceived: true,
timestamp: 4,
quote: {
authorAci: CONTACT_A,
attachments: [],
id: 3,
id: 42,
text: 'quote text',
isViewOnce: false,
isGiftBadge: true,
messageId: '',
referencedMessageNotFound: false,
isGiftBadge: false,
referencedMessageNotFound: true,
},
},
]);
} as const;
await asymmetricRoundtripHarness(
[message],
[
{
...message,
quote: {
...message.quote,
// id is removed during roundtrip
id: null,
},
},
]
);
});
// TODO (DESKTOP-7899): Roundtrip view-once quotes
});
it('roundtrips sealed/unsealed incoming message', async () => {