Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 12:19:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix benchmark CI misattribution & flake

Browse Source 
Co-authored-by: trevor-signal <131492920+trevor-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2025-09-08 11:19:43 -05:00
committed by GitHub
parent 4c3a3efb01
commit 56b11c1716
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/benchmark.yml vendored
View File

@@ -52,7 +52,7 @@ jobs:
contactCount: 500 contactCount: 500
discardCount: 2 discardCount: 2
- metric: convoOpen - metric: convoOpen
script: ts/test-mock/benchmarks/group_send_bench.js script: ts/test-mock/benchmarks/convo_open_bench.js
runCount: 100 runCount: 100
- metric: callHistorySearch - metric: callHistorySearch
script: ts/test-mock/benchmarks/call_history_search_bench.js script: ts/test-mock/benchmarks/call_history_search_bench.js

4
ts/test-mock/benchmarks/group_send_bench.ts
View File

@@ -140,12 +140,12 @@ Bootstrap.benchmark(async (bootstrap: Bootstrap): Promise<void> => {
{ {
const leftPane = window.locator('#LeftPane'); const leftPane = window.locator('#LeftPane');
// Left pane should show either the message preview or // Wait for group state to be fetched
// "You were added to the group".
await leftPane await leftPane
.locator( .locator(
`.module-conversation-list__item--contact-or-conversation[data-testid="${group.id}"]` `.module-conversation-list__item--contact-or-conversation[data-testid="${group.id}"]`
) )
.getByText(GROUP_NAME)
.waitFor(); .waitFor();
} }