From 5dbdf58f371c2f2fb39dbc10a82813404fbfe853 Mon Sep 17 00:00:00 2001 From: automated-signal <37887102+automated-signal@users.noreply.github.com> Date: Wed, 23 Jun 2021 11:19:04 -0700 Subject: [PATCH] Fix check for successfull delivery Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com> --- ts/models/conversations.ts | 2 +- ts/models/messages.ts | 5 +++++ ts/views/conversation_view.ts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ts/models/conversations.ts b/ts/models/conversations.ts index e71ec491ba..3a3a28ab2b 100644 --- a/ts/models/conversations.ts +++ b/ts/models/conversations.ts @@ -3259,7 +3259,7 @@ export class ConversationModel extends window.Backbone 'Error sending deleteForEveryone', deleteModel, targetTimestamp, - error + error && error.stack ); throw error; diff --git a/ts/models/messages.ts b/ts/models/messages.ts index 2dabd4f6fc..e22d911c70 100644 --- a/ts/models/messages.ts +++ b/ts/models/messages.ts @@ -1430,6 +1430,11 @@ export class MessageModel extends window.Backbone.Model { } public hasSuccessfulDelivery(): boolean { + const recipients = this.get('recipients') || []; + if (recipients.length === 0) { + return true; + } + return (this.get('sent_to') || []).length !== 0; } diff --git a/ts/views/conversation_view.ts b/ts/views/conversation_view.ts index 68ff2158f1..5ad0e4c08b 100644 --- a/ts/views/conversation_view.ts +++ b/ts/views/conversation_view.ts @@ -2937,7 +2937,7 @@ Whisper.ConversationView = Whisper.View.extend({ } catch (error) { window.log.error( 'Error sending delete-for-everyone', - error, + error && error.stack, messageId ); this.showToast(Whisper.DeleteForEveryoneFailedToast);