Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-25 02:48:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve speed of getUnreadByConversationAndMarkRead query

Browse Source
This commit is contained in:
trevor-signal
2025-11-13 14:00:35 -05:00
committed by GitHub
parent 8e79bb5050
commit 616fd1a536
5 changed files with 36 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
ts/test-node/sql/migration_1530_test.node.ts → ts/test-node/sql/migration_1540_test.node.ts
View File

@@ -6,12 +6,12 @@ import { type WritableDB } from '../../sql/Interface.std.js';
import { sql, sqlFragment } from '../../sql/util.std.js';
import { createDB, explain, updateToVersion } from './helpers.node.js';
describe('SQL/updateToSchemaVersion1530', () => {
describe('SQL/updateToSchemaVersion1540', () => {
let db: WritableDB;
beforeEach(() => {
db = createDB();
updateToVersion(db, 1530);
updateToVersion(db, 1540);
});
afterEach(() => {
db.close();
@@ -19,6 +19,7 @@ describe('SQL/updateToSchemaVersion1530', () => {
const CORE_UPDATE_QUERY = sqlFragment`
UPDATE messages
INDEXED BY messages_conversationId_expirationStartTimestamp
SET
expirationStartTimestamp = 342342
WHERE
@@ -48,8 +49,8 @@ describe('SQL/updateToSchemaVersion1530', () => {
assert.strictEqual(
detail,
'SEARCH messages USING INDEX messages_conversationId_hasExpireTimer_expirationStartTimestamp' +
' (conversationId=? AND hasExpireTimer=? AND expirationStartTimestamp=?)'
'SEARCH messages USING INDEX messages_conversationId_expirationStartTimestamp' +
' (conversationId=? AND expirationStartTimestamp=?)'
);
});
it('uses index efficiently with null start + no storyId condition', () => {
@@ -62,8 +63,8 @@ describe('SQL/updateToSchemaVersion1530', () => {
assert.strictEqual(
detail,
'SEARCH messages USING INDEX messages_conversationId_hasExpireTimer_expirationStartTimestamp' +
' (conversationId=? AND hasExpireTimer=? AND expirationStartTimestamp=?)'
'SEARCH messages USING INDEX messages_conversationId_expirationStartTimestamp' +
' (conversationId=? AND expirationStartTimestamp=?)'
);
});
@@ -72,8 +73,8 @@ describe('SQL/updateToSchemaVersion1530', () => {
assert.strictEqual(
detail,
'SEARCH messages USING INDEX messages_conversationId_hasExpireTimer_expirationStartTimestamp' +
' (conversationId=? AND hasExpireTimer=? AND expirationStartTimestamp>?)'
'SEARCH messages USING INDEX messages_conversationId_expirationStartTimestamp' +
' (conversationId=? AND expirationStartTimestamp>?)'
);
});
@@ -86,8 +87,8 @@ describe('SQL/updateToSchemaVersion1530', () => {
assert.strictEqual(
detail,
'SEARCH messages USING INDEX messages_conversationId_hasExpireTimer_expirationStartTimestamp' +
' (conversationId=? AND hasExpireTimer=? AND expirationStartTimestamp>?)'
'SEARCH messages USING INDEX messages_conversationId_expirationStartTimestamp' +
' (conversationId=? AND expirationStartTimestamp>?)'
);
});
});