Simplify copyQuote logic

This commit is contained in:
Fedor Indutny
2024-09-04 15:59:39 -07:00
committed by GitHub
parent 0d5a480c1b
commit 68223aaa12
7 changed files with 106 additions and 167 deletions
+9 -17
View File
@@ -18,14 +18,14 @@ describe('MessageCache', () => {
await window.ConversationController.load();
});
describe('filterBySentAt', () => {
it('returns an empty iterable if no messages match', () => {
describe('findBySentAt', () => {
it('returns an empty iterable if no messages match', async () => {
const mc = new MessageCache();
assert.isEmpty([...mc.__DEPRECATED$filterBySentAt(123)]);
assert.isUndefined(await mc.findBySentAt(123, () => true));
});
it('returns all messages that match the timestamp', () => {
it('returns all messages that match the timestamp', async () => {
const mc = new MessageCache();
let message1 = new MessageModel({
@@ -62,23 +62,15 @@ describe('MessageCache', () => {
message2 = mc.__DEPRECATED$register(message2.id, message2, 'test');
mc.__DEPRECATED$register(message3.id, message3, 'test');
const filteredMessages = Array.from(
mc.__DEPRECATED$filterBySentAt(1234)
).map(x => x.attributes);
const filteredMessage = await mc.findBySentAt(1234, () => true);
assert.deepEqual(
filteredMessages,
[message1.attributes, message2.attributes],
'first'
);
assert.deepEqual(filteredMessage, message1.attributes, 'first');
mc.__DEPRECATED$unregister(message2.id);
mc.__DEPRECATED$unregister(message1.id);
const filteredMessages2 = Array.from(
mc.__DEPRECATED$filterBySentAt(1234)
).map(x => x.attributes);
const filteredMessage2 = await mc.findBySentAt(1234, () => true);
assert.deepEqual(filteredMessages2, [message1.attributes], 'second');
assert.deepEqual(filteredMessage2, message2.attributes, 'second');
});
});