Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-05-08 08:58:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Migrate react-contextmenu menus to axo menus

Browse Source 
Co-authored-by: Fedor Indutny <indutny@signal.org>
This commit is contained in:
Jamie
2025-11-12 09:31:52 -08:00
committed by GitHub
parent 7d52f761e3
commit 714e161671
37 changed files with 1366 additions and 1693 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ts/util/lint/exceptions.json
+39 -53
View File
@@ -825,6 +825,13 @@
"reasonCategory": "usageTrusted",
"updated": "2025-08-28T23:36:44.974Z"
},
{
"rule": "React-useRef",
"path": "ts/axo/AxoContextMenu.dom.tsx",
"line": " useRef<TriggerElementGetter>(getTriggerElement);",
"reasonCategory": "usageTrusted",
"updated": "2025-11-11T22:17:13.219Z"
},
{
"rule": "React-useRef",
"path": "ts/axo/AxoDropdownMenu.dom.tsx",
@@ -1148,13 +1155,6 @@
"reasonCategory": "usageTrusted",
"updated": "2021-07-30T16:57:33.618Z"
},
{
"rule": "React-useRef",
"path": "ts/components/ChatColorPicker.dom.tsx",
"line": " const menuRef = useRef<any | null>(null);",
"reasonCategory": "usageTrusted",
"updated": "2021-07-30T16:57:33.618Z"
},
{
"rule": "React-useRef",
"path": "ts/components/CompositionArea.dom.tsx",
@@ -1169,6 +1169,14 @@
"reasonCategory": "usageTrusted",
"updated": "2021-09-23T00:07:11.885Z"
},
{
"rule": "React-useRef",
"path": "ts/components/CompositionArea.dom.tsx",
"line": " const photoVideoInputRef = useRef<null | HTMLInputElement>(null);",
"reasonCategory": "usageTrusted",
"updated": "2025-10-27T16:28:11.852Z",
"reasonDetail": "Ref for photo/video file input element"
},
{
"rule": "React-useRef",
"path": "ts/components/CompositionInput.dom.tsx",
@@ -1492,6 +1500,22 @@
"updated": "2022-09-14T16:20:15.384Z",
"reasonDetail": "Holds a reference to a container element to prevent outside clicks"
},
{
"rule": "React-useRef",
"path": "ts/components/PollCreateModal.dom.tsx",
"line": " const optionRefsMap = useRef<Map<string, HTMLTextAreaElement | null>>(",
"reasonCategory": "usageTrusted",
"updated": "2025-11-02T17:27:24.705Z",
"reasonDetail": "Map of refs for poll option inputs to manage focus"
},
{
"rule": "React-useRef",
"path": "ts/components/PollCreateModal.dom.tsx",
"line": " const questionInputRef = useRef<HTMLTextAreaElement | null>(null);",
"reasonCategory": "usageTrusted",
"updated": "2025-11-02T17:27:24.705Z",
"reasonDetail": "Ref for question input to manage focus on validation errors"
},
{
"rule": "React-useRef",
"path": "ts/components/Preferences.dom.tsx",
@@ -1735,20 +1759,6 @@
"updated": "2025-05-28T00:57:39.376Z",
"reasonDetail": "Holding on to a close function"
},
{
"rule": "React-useRef",
"path": "ts/components/conversation/CallingNotification.dom.tsx",
"line": " const menuTriggerRef = React.useRef<ContextMenuTriggerType | null>(null);",
"reasonCategory": "usageTrusted",
"updated": "2023-12-08T20:28:57.595Z"
},
{
"rule": "React-useRef",
"path": "ts/components/conversation/ConversationHeader.dom.tsx",
"line": " const menuTriggerRef = useRef<any>(null);",
"reasonCategory": "usageTrusted",
"updated": "2024-03-15T18:29:48.327Z"
},
{
"rule": "React-useRef",
"path": "ts/components/conversation/ConversationHeader.dom.tsx",
@@ -1931,6 +1941,14 @@
"updated": "2024-09-03T00:45:23.978Z",
"reasonDetail": "Because we need the current tab value outside the callback"
},
{
"rule": "React-useRef",
"path": "ts/components/conversation/poll-message/PollMessageContents.dom.tsx",
"line": " const pendingCheckTimer = useRef<NodeJS.Timeout | null>(null);",
"reasonCategory": "usageTrusted",
"updated": "2025-11-06T20:28:00.760Z",
"reasonDetail": "Ref for timer"
},
{
"rule": "React-useRef",
"path": "ts/components/fun/FunGif.dom.tsx",
@@ -2334,37 +2352,5 @@
"line": " message.innerHTML = window.SignalContext.i18n('icu:optimizingApplication');",
"reasonCategory": "usageTrusted",
"updated": "2021-09-17T21:02:59.414Z"
},
{
"rule": "React-useRef",
"path": "ts/components/CompositionArea.dom.tsx",
"line": " const photoVideoInputRef = useRef<null | HTMLInputElement>(null);",
"reasonCategory": "usageTrusted",
"updated": "2025-10-27T16:28:11.852Z",
"reasonDetail": "Ref for photo/video file input element"
},
{
"rule": "React-useRef",
"path": "ts/components/PollCreateModal.dom.tsx",
"line": " const questionInputRef = useRef<HTMLTextAreaElement | null>(null);",
"reasonCategory": "usageTrusted",
"updated": "2025-11-02T17:27:24.705Z",
"reasonDetail": "Ref for question input to manage focus on validation errors"
},
{
"rule": "React-useRef",
"path": "ts/components/PollCreateModal.dom.tsx",
"line": " const optionRefsMap = useRef<Map<string, HTMLTextAreaElement | null>>(",
"reasonCategory": "usageTrusted",
"updated": "2025-11-02T17:27:24.705Z",
"reasonDetail": "Map of refs for poll option inputs to manage focus"
},
{
"rule": "React-useRef",
"path": "ts/components/conversation/poll-message/PollMessageContents.dom.tsx",
"line": " const pendingCheckTimer = useRef<NodeJS.Timeout | null>(null);",
"reasonCategory": "usageTrusted",
"updated": "2025-11-06T20:28:00.760Z",
"reasonDetail": "Ref for timer"
}
]
ts/util/lint/linter.node.ts
-1
View File
@@ -94,7 +94,6 @@ const excludedFilesRegexp = RegExp(
'^node_modules/lodash/.+',
'^node_modules/react/.+',
'^node_modules/react-aria-components/.+',
'^node_modules/react-contextmenu/.+',
'^node_modules/react-dom/.+',
'^node_modules/react-icon-base/.+',
'^node_modules/react-input-autosize/.+',