Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-05-03 22:55:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Stories: Only render text link if it's a valid URL

Browse Source
This commit is contained in:
Scott Nonnenberg
2024-09-14 07:34:48 +10:00
committed by GitHub
parent 2ee7b18d33
commit 733c5b598f
3 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
ts/test-node/types/LinkPreview_test.ts
View File

@@ -5,12 +5,36 @@ import { assert } from 'chai';
import {
findLinks,
isLinkSneaky,
isValidLink,
shouldLinkifyMessage,
shouldPreviewHref,
isLinkSneaky,
} from '../../types/LinkPreview';
describe('Link previews', () => {
describe('#isValidLink', () => {
it('returns false for random, non-https URLs', () => {
assert.isFalse(isValidLink(''));
assert.isFalse(isValidLink('signal.com'));
assert.isFalse(isValidLink('signal.org'));
assert.isFalse(isValidLink('https'));
assert.isFalse(isValidLink('https://'));
assert.isFalse(isValidLink('https://bad url'));
assert.isFalse(isValidLink('http://signal.org'));
});
it('returns true for https:// URLs', () => {
assert.isTrue(isValidLink('https://signal.org'));
assert.isTrue(isValidLink('https://somewhere.someplace.signal.org/'));
assert.isTrue(isValidLink('https://signal.org/something/another/#thing'));
assert.isTrue(
isValidLink(
'https://signal.org/something/another/?one=two&three=four#thing'
)
);
});
});
describe('#shouldPreviewHref', () => {
it('returns false for invalid URLs', () => {
assert.isFalse(shouldPreviewHref(''));