From 785a695ad58310bb77d7fb5e802f3f94d2d71b23 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Thu, 5 Feb 2026 04:27:16 +1000 Subject: [PATCH] storageRecordOps.toRecipient: Allow for missing recipients --- ts/services/storageRecordOps.preload.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/ts/services/storageRecordOps.preload.ts b/ts/services/storageRecordOps.preload.ts index 72d10fdd3d..160f8a6690 100644 --- a/ts/services/storageRecordOps.preload.ts +++ b/ts/services/storageRecordOps.preload.ts @@ -853,11 +853,14 @@ export function toDefunctOrPendingCallLinkRecord( function toRecipient( conversationId: string, logPrefix: string -): Proto.Recipient { +): Proto.Recipient | undefined { const conversation = window.ConversationController.get(conversationId); if (conversation == null) { - throw new Error(`${logPrefix}/toRecipient: Missing conversation`); + log.error( + `${logPrefix}/toRecipient: Missing conversation with id ${conversationId}` + ); + return undefined; } const logId = `${logPrefix}/toRecipient(${conversation.idForLogging()})`; @@ -903,9 +906,11 @@ function toRecipients( conversationIds: ReadonlyArray, logPrefix: string ): Array { - return conversationIds.map(conversationId => { - return toRecipient(conversationId, logPrefix); - }); + return conversationIds + .map(conversationId => { + return toRecipient(conversationId, logPrefix); + }) + .filter(isNotNil); } function toChatFolderRecordFolderType(