Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-24 18:38:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Throw error if incoming attachment has mismatched attachment size

Browse Source
This commit is contained in:
Scott Nonnenberg
2019-02-15 13:43:22 -08:00
parent f5af063191
commit 7c4ba5446c
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libtextsecure/message_receiver.js
View File

@@ -1216,7 +1216,7 @@ MessageReceiver.prototype.extend({
},
async downloadAttachment(attachment) {
const encrypted = await this.server.getAttachment(attachment.id);
const { key, digest } = attachment;
const { key, digest, size } = attachment;
const data = await textsecure.crypto.decryptAttachment(
encrypted,
@@ -1224,6 +1224,14 @@ MessageReceiver.prototype.extend({
window.Signal.Crypto.base64ToArrayBuffer(digest)
);
if (!size || size !== data.byteLength) {
throw new Error(
`downloadAttachment: Size ${size} did not match downloaded attachment size ${
data.byteLength
}`
);
}
return {
..._.omit(attachment, 'digest', 'key'),
data,