Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-20 02:08:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix sass deprecation warnings and make them fatal

Browse Source
This commit is contained in:
Jamie Kyle
2025-05-04 19:57:44 -07:00
committed by GitHub
parent 4cc088c79e
commit 80872ef15c
6 changed files with 26 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@@ -30,7 +30,7 @@
"mark-unusued-strings-deleted": "ts-node ./ts/scripts/mark-unused-strings-deleted.ts",
"get-expire-time": "node ts/scripts/get-expire-time.js",
"copy-components": "node ts/scripts/copy.js",
"sass": "sass stylesheets/manifest.scss:stylesheets/manifest.css stylesheets/manifest_bridge.scss:stylesheets/manifest_bridge.css",
"sass": "sass stylesheets/manifest.scss:stylesheets/manifest.css stylesheets/manifest_bridge.scss:stylesheets/manifest_bridge.css --fatal-deprecation=1.80.7",
"build-module-protobuf": "pbjs --root='signal-desktop' --target static-module --force-long --no-typeurl --no-verify --no-create --no-convert --wrap commonjs --out ts/protobuf/compiled.js protos/*.proto && pbts --no-comments --out ts/protobuf/compiled.d.ts ts/protobuf/compiled.js",
"clean-module-protobuf": "rm -f ts/protobuf/compiled.d.ts ts/protobuf/compiled.js",
"build-protobuf": "pnpm run build-module-protobuf",

23
stylesheets/_modules.scss
View File

@@ -932,19 +932,18 @@ $message-padding-horizontal: 12px;
@include mixins.button-reset;
& {
@include mixins.font-body-1;
@include mixins.light-theme {
border-block-start-color: variables.$color-black-alpha-10;
}
@include mixins.dark-theme {
border-block-start-color: variables.$color-white-alpha-10;
}
width: calc(100% + 24px);
margin-block-start: 9px;
margin-inline: -12px;
padding-block-start: 9px;
padding-inline: 12px;
border-block-start: 0.5px solid;
@include mixins.light-theme {
border-block-start-color: variables.$color-black-alpha-10;
}
@include mixins.dark-theme {
border-block-start-color: variables.$color-white-alpha-10;
}
}
}
@@ -4781,11 +4780,6 @@ button.module-image__border-overlay:focus {
opacity: 0;
transition: all 0.5s variables.$ease-out-local-preview;
&--visible {
opacity: 1;
bottom: 4px;
}
display: flex;
align-items: center;
flex-direction: row;
@@ -4794,6 +4788,11 @@ button.module-image__border-overlay:focus {
justify-content: space-around;
background-color: variables.$color-gray-78;
&--visible {
opacity: 1;
bottom: 4px;
}
&__spacer {
flex-grow: 1;
flex-shrink: 1;

4
stylesheets/components/CriticalIdlePrimaryDeviceModal.scss
View File

@@ -18,12 +18,12 @@
&::after {
content: '';
display: block;
width: 52px;
height: 52px;
@include mixins.color-svg(
'../images/icons/v3/error/error-circle.svg',
variables.$color-orange
);
width: 52px;
height: 52px;
}
}

4
stylesheets/components/LowDiskSpaceBackupImportModal.scss
View File

@@ -21,12 +21,12 @@
&::after {
content: '';
display: block;
width: 32px;
height: 32px;
@include mixins.color-svg(
'../images/icons/v3/backup/backup-warning.svg',
variables.$color-black
);
width: 32px;
height: 32px;
}
}

3
stylesheets/components/PlaybackButton.scss
View File

@@ -7,9 +7,8 @@
.PlaybackButton {
@include mixins.button-reset;
position: relative;
& {
position: relative;
flex-shrink: 0;
margin-inline-end: MessageAudio.$audio-attachment-button-margin-big;

18
stylesheets/components/SignalConversationMuteToggle.scss
View File

@@ -5,6 +5,15 @@
@use '../variables';
.SignalConversationMuteToggle {
height: variables.$header-height;
display: flex;
justify-content: center;
align-items: center;
font-size: 14px;
color: variables.$color-ultramarine-light;
@include mixins.light-theme() {
background-color: variables.$color-white;
border-top: 0.5px solid variables.$color-black-alpha-16;
@@ -15,15 +24,6 @@
border-top: 0.5px solid variables.$color-gray-65;
}
height: variables.$header-height;
display: flex;
justify-content: center;
align-items: center;
font-size: 14px;
color: variables.$color-ultramarine-light;
&__text {
@include mixins.button-reset;
}